Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html

Issue 2681993002: EME: Allow case-insensitive parameter names in media MIME types (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html
diff --git a/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html b/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html
index 8f132b2032c9dc60f5dadd8f288abecb69032597..9a3fca187108ed60c05be564cefeeba0779def44 100644
--- a/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html
+++ b/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html
@@ -245,39 +245,45 @@
}, 'Space at end of codecs parameter');
// contentType is not case sensitive (except the codec names).
+ // From RFC 2045: "All media type values, subtype values, and
+ // parameter names as defined are case-insensitive. However,
+ // parameter values are case-sensitive unless otherwise specified
+ // for the specific parameter."
expect_config('org.w3.clearkey', [{
videoCapabilities: [{contentType: 'Video/webm; codecs="vp8"'}],
}], {
videoCapabilities: [{contentType: 'Video/webm; codecs="vp8"'}],
- }, 'Video/webm');
+ }, 'Media type value is case-insensitive');
expect_config('org.w3.clearkey', [{
videoCapabilities: [{contentType: 'video/Webm; codecs="vp8"'}],
}], {
videoCapabilities: [{contentType: 'video/Webm; codecs="vp8"'}],
- }, 'video/Webm');
-
- expect_config('org.w3.clearkey', [{
- videoCapabilities: [{contentType: 'video/webm; Codecs="vp8"'}],
- }], {
- videoCapabilities: [{contentType: 'video/webm; Codecs="vp8"'}],
- }, 'Codecs=');
+ }, 'Media subtype value is case-insensitive');
expect_config('org.w3.clearkey', [{
videoCapabilities: [{contentType: 'VIDEO/WEBM; codecs="vp8"'}],
}], {
videoCapabilities: [{contentType: 'VIDEO/WEBM; codecs="vp8"'}],
- }, 'VIDEO/WEBM');
+ }, 'Media type values and subtype values are case-insensitive');
expect_config('org.w3.clearkey', [{
videoCapabilities: [{contentType: 'video/webm; CODECS="vp8"'}],
}], {
videoCapabilities: [{contentType: 'video/webm; CODECS="vp8"'}],
- }, 'CODECS=');
+ }, 'Media parameter name is case-insensitive');
+
+ expect_error('org.w3.clearkey', [{
+ videoCapabilities: [{contentType: 'video/webm; CODECS="foo"'}],
+ }], 'NotSupportedError', 'Unsupported codec');
+
+ expect_error('org.w3.clearkey', [{
+ videoCapabilities: [{contentType: 'video/webm; codecs="VP8"'}],
+ }], 'NotSupportedError', 'Codec is case-sensitive');
// Unrecognized attributes are not allowed.
// TODO(jrummell): Unrecognized attributes are ignored currently.
- // http://crbug.com/449690
+ // http://crbug.com/690131
// expect_error('org.w3.clearkey', [{
// videoCapabilities: [{contentType: 'video/webm; foo="bar"'}],
// }], 'NotSupportedError', 'Unrecognized foo');
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698