content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostDelegate.java - Issue 2681933002: Add Java wrapper for RenderFrameHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostDelegate.java

Issue 2681933002: Add Java wrapper for RenderFrameHost (Closed)

Patch Set: Try to address all review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 package org.chromium.content.browser.framehost;

	6

	7 import org.chromium.content_public.browser.WebContents;

	8

	9 /**

	10 * The RenderFrameHost Java wrapper to allow communicating with the native Rende rFrameHost object.

	11 *

	12 */

	13 public interface RenderFrameHostDelegate {

	14 /**

	15 * @return The WebContents associated with this iframe.

	16 */

	17 WebContents getAsWebContents();
	boliu 2017/03/06 23:12:38 this is still here? WebContentsImpl should be cas this is still here? WebContentsImpl should be casting (maybe with an instanceof check) rwlbuis 2017/03/07 19:44:55 Done. Sorry I did not realize it was that simple! Show quoted text On 2017/03/06 23:12:38, boliu wrote: > this is still here? > > WebContentsImpl should be casting (maybe with an instanceof check) Done. Sorry I did not realize it was that simple! :)
	18 }

OLD	NEW