content/browser/media/session/media_session_impl_visibility_browsertest.cc - Issue 2681863005: [Video] MediaSession API event handlers can resume background video.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/session/media_session_impl_visibility_browsertest.cc

Issue 2681863005: [Video] MediaSession API event handlers can resume background video. (Closed)

Patch Set: Restore permanent 5s pause. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/renderer/media/renderer_webmediaplayer_delegate.cc » ('j') | content/renderer/media/renderer_webmediaplayer_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/session/media_session_impl_visibility_browsertest.cc

diff --git a/content/browser/media/session/media_session_impl_visibility_browsertest.cc b/content/browser/media/session/media_session_impl_visibility_browsertest.cc

index a6840e57edf4a378f0127ed7e920bf716e0419d2..6950ed341c8622e027df4ec02e494bdcef80b361 100644

--- a/content/browser/media/session/media_session_impl_visibility_browsertest.cc

+++ b/content/browser/media/session/media_session_impl_visibility_browsertest.cc

@@ -176,7 +176,7 @@ class MediaSessionImplVisibilityBrowserTest

if (state_before_hide == state_after_hide) {

LOG(INFO) << "Waiting for 1 second and check session state is unchanged";

Wait(base::TimeDelta::FromSeconds(1));

- ASSERT_EQ(media_session_->audio_focus_state_, state_after_hide);

+ ASSERT_EQ(state_after_hide, media_session_->audio_focus_state_);

} else {

LOG(INFO) << "Waiting for Session to change";

WaitForMediaSessionState(state_after_hide);

« no previous file with comments | « no previous file | content/renderer/media/renderer_webmediaplayer_delegate.cc » ('j') | content/renderer/media/renderer_webmediaplayer_delegate.cc » ('J')