Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc

Issue 2681783004: Use Initial Containing Block size for vertical (Closed)
Patch Set: Final CR fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..38ebd90e52305b9a4a99a071caea63764ddb8784
--- /dev/null
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder_test.cc
@@ -0,0 +1,73 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/layout/ng/ng_constraint_space_builder.h"
+#include "core/layout/ng/ng_units.h"
+
+#include "core/layout/LayoutTestHelper.h"
+
+namespace blink {
+namespace {
+
+class NGConstraintSpaceBuilderTest {
+ public:
+ NGConstraintSpaceBuilderTest() {
+ RuntimeEnabledFeatures::setLayoutNGEnabled(true);
+ };
+ ~NGConstraintSpaceBuilderTest() {
+ RuntimeEnabledFeatures::setLayoutNGEnabled(false);
+ };
+};
+
+// Asserts that indefinite inline length becomes initial containing
+// block width for horizontal-tb inside vertical document.
+TEST(NGConstraintSpaceBuilderTest, AvailableSizeFromHorizontalICB) {
+ NGConstraintSpaceBuilder horizontal_builder(kHorizontalTopBottom);
+ NGLogicalSize fixed_size{LayoutUnit(100), LayoutUnit(200)};
+ NGLogicalSize indefinite_size{NGSizeIndefinite, NGSizeIndefinite};
+ NGPhysicalSize icb_size{NGSizeIndefinite, LayoutUnit(51)};
+
+ horizontal_builder.SetInitialContainingBlockSize(icb_size);
+ horizontal_builder.SetAvailableSize(fixed_size);
+ horizontal_builder.SetPercentageResolutionSize(fixed_size);
+
+ NGConstraintSpaceBuilder vertical_builder(
+ horizontal_builder.ToConstraintSpace());
+
+ vertical_builder.SetAvailableSize(indefinite_size);
+ vertical_builder.SetPercentageResolutionSize(indefinite_size);
+ vertical_builder.SetWritingMode(kVerticalLeftRight);
+ NGConstraintSpace* space = vertical_builder.ToConstraintSpace();
+
+ EXPECT_EQ(space->AvailableSize().inline_size, icb_size.height);
+ EXPECT_EQ(space->PercentageResolutionSize().inline_size, icb_size.height);
+};
+
+// Asserts that indefinite inline length becomes initial containing
+// block height for vertical-lr inside horizontal document.
+TEST(NGConstraintSpaceBuilderTest, AvailableSizeFromVerticalICB) {
+ NGConstraintSpaceBuilder horizontal_builder(kVerticalLeftRight);
+ NGLogicalSize fixed_size{LayoutUnit(100), LayoutUnit(200)};
+ NGLogicalSize indefinite_size{NGSizeIndefinite, NGSizeIndefinite};
+ NGPhysicalSize icb_size{LayoutUnit(51), NGSizeIndefinite};
+
+ horizontal_builder.SetInitialContainingBlockSize(icb_size);
+ horizontal_builder.SetAvailableSize(fixed_size);
+ horizontal_builder.SetPercentageResolutionSize(fixed_size);
+
+ NGConstraintSpaceBuilder vertical_builder(
+ horizontal_builder.ToConstraintSpace());
+
+ vertical_builder.SetAvailableSize(indefinite_size);
+ vertical_builder.SetPercentageResolutionSize(indefinite_size);
+ vertical_builder.SetWritingMode(kHorizontalTopBottom);
+ NGConstraintSpace* space = vertical_builder.ToConstraintSpace();
+
+ EXPECT_EQ(space->AvailableSize().inline_size, icb_size.width);
+ EXPECT_EQ(space->PercentageResolutionSize().inline_size, icb_size.width);
+};
+
+} // namespace
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698