Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 2681733007: When addSource() in tests, call both addFile() and changeFile(). (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When addSource() in tests, call both addFile() and changeFile(). This fixes the two failing tests. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/af539081cd191b03d2f5dafebac9d9b67cb9c2d0

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/analysis_server/test/abstract_context.dart View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 10 months ago (2017-02-09 16:30:46 UTC) #1
Brian Wilkerson
https://codereview.chromium.org/2681733007/diff/1/pkg/analysis_server/test/abstract_context.dart File pkg/analysis_server/test/abstract_context.dart (right): https://codereview.chromium.org/2681733007/diff/1/pkg/analysis_server/test/abstract_context.dart#newcode89 pkg/analysis_server/test/abstract_context.dart:89: driver.changeFile(path); Should `addFile` be extended to also always do ...
3 years, 10 months ago (2017-02-09 16:43:54 UTC) #2
scheglov
https://codereview.chromium.org/2681733007/diff/1/pkg/analysis_server/test/abstract_context.dart File pkg/analysis_server/test/abstract_context.dart (right): https://codereview.chromium.org/2681733007/diff/1/pkg/analysis_server/test/abstract_context.dart#newcode89 pkg/analysis_server/test/abstract_context.dart:89: driver.changeFile(path); On 2017/02/09 16:43:54, Brian Wilkerson wrote: > Should ...
3 years, 10 months ago (2017-02-09 16:48:04 UTC) #3
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-09 16:49:04 UTC) #4
scheglov
3 years, 10 months ago (2017-02-09 16:51:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
af539081cd191b03d2f5dafebac9d9b67cb9c2d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698