NTP Cleanup: Remove support for "icons" layout

chrome/renderer/resources/extensions/searchbox_api.js

Index: chrome/renderer/resources/extensions/searchbox_api.js
diff --git a/chrome/renderer/resources/extensions/searchbox_api.js b/chrome/renderer/resources/extensions/searchbox_api.js
index 189e2b301801dc34a3a32814b649c97182e61c11..36f23dace515f7fe6ec94164c0fb8321f88fdf69 100644
--- a/chrome/renderer/resources/extensions/searchbox_api.js
+++ b/chrome/renderer/resources/extensions/searchbox_api.js
@@ -82,8 +82,6 @@ if (!chrome.embeddedSearch) {
           delete item.domain;
           delete item.direction;
           delete item.renderViewId;
-          delete item.largeIconUrl;
-          delete item.fallbackIconUrl;
         }
         return mostVisitedItems;
       }
@@ -116,21 +114,7 @@ if (!chrome.embeddedSearch) {
       // This method is restricted to chrome-search://most-visited pages by
       // checking the invoking context's origin in searchbox_extension.cc.
       this.getMostVisitedItemData = function(restrictedId) {

[mastiz, 2017/02/08 13:59:22]

Seems like the signature matches. Do you even need the lambda?

[Marc Treib, 2017/02/08 14:02:48]

The inner GetMostVisitedItemData is a native function (see definition above), I
think it's not possible to expose that directly, hence the wrapper. All the
other exposed functions do the same thing.

-        var item = GetMostVisitedItemData(restrictedId);
-        if (item) {
-          var sizeInPx = Math.floor(48 * window.devicePixelRatio + 0.5);
-          // Populate large icon and fallback icon data, if they exist. We'll
-          // render everything here, once these become available by default.
-          if (item.largeIconUrl) {
-            item.largeIconUrl +=
-                sizeInPx + "/" + item.renderViewId + "/" + item.rid;
-          }
-          if (item.fallbackIconUrl) {
-            item.fallbackIconUrl +=
-                sizeInPx + ",,,,/" + item.renderViewId + "/" + item.rid;
-          }
-        }
-        return item;
+        return GetMostVisitedItemData(restrictedId);
       };
 
       // This method is restricted to chrome-search://most-visited pages by