NTP Cleanup: Remove support for "icons" layout

chrome/renderer/resources/extensions/searchbox_api.js

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var chrome;
 if (!chrome)
   chrome = {};
 
 if (!chrome.embeddedSearch) {
   chrome.embeddedSearch = new function() {
@@ skipping 64 matching lines @@
         for (var i = 0, item; item = mostVisitedItems[i]; ++i) {
           item.faviconUrl = GenerateFaviconURL(item.renderViewId, item.rid);
 
           // These properties are private data and should not be returned to
           // the page. They are only accessible via getMostVisitedItemData().
           delete item.url;
           delete item.title;
           delete item.domain;
           delete item.direction;
           delete item.renderViewId;
-          delete item.largeIconUrl;
-          delete item.fallbackIconUrl;
         }
         return mostVisitedItems;
       }
 
       function GenerateFaviconURL(renderViewId, rid) {
         return "chrome-search://favicon/size/16@" +
             window.devicePixelRatio + "x/" +
             renderViewId + "/" + rid;
       }
 
@@ skipping 11 matching lines @@
       this.checkIsUserSyncingHistory = function() {
         CheckIsUserSyncingHistory();
       };
 
       this.deleteMostVisitedItem = function(restrictedId) {
         DeleteMostVisitedItem(restrictedId);
       };
 
       // This method is restricted to chrome-search://most-visited pages by
       // checking the invoking context's origin in searchbox_extension.cc.
       this.getMostVisitedItemData = function(restrictedId) {

[mastiz, 2017/02/08 13:59:22]

Seems like the signature matches. Do you even need the lambda?

[Marc Treib, 2017/02/08 14:02:48]

The inner GetMostVisitedItemData is a native function (see definition above), I
think it's not possible to expose that directly, hence the wrapper. All the
other exposed functions do the same thing.

-        var item = GetMostVisitedItemData(restrictedId);
-        if (item) {
-          var sizeInPx = Math.floor(48 * window.devicePixelRatio + 0.5);
-          // Populate large icon and fallback icon data, if they exist. We'll
-          // render everything here, once these become available by default.
-          if (item.largeIconUrl) {
-            item.largeIconUrl +=
-                sizeInPx + "/" + item.renderViewId + "/" + item.rid;
-          }
-          if (item.fallbackIconUrl) {
-            item.fallbackIconUrl +=
-                sizeInPx + ",,,,/" + item.renderViewId + "/" + item.rid;
-          }
-        }
-        return item;
+        return GetMostVisitedItemData(restrictedId);
       };
 
       // This method is restricted to chrome-search://most-visited pages by
       // checking the invoking context's origin in searchbox_extension.cc.
       this.logEvent = function(histogram_name) {
         LogEvent(histogram_name);
       };
 
       // This method is restricted to chrome-search://most-visited pages by
       // checking the invoking context's origin in searchbox_extension.cc.
@@ skipping 20 matching lines @@
       this.oninputcancel = null;
       this.oninputstart = null;
       this.onmostvisitedchange = null;
       this.onthemechange = null;
     };
 
     // TODO(jered): Remove when google no longer expects this object.
     chrome.searchBox = this.searchBox;
   };
 }