editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java - Issue 26817006: Don't resolve private inherited members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

Issue 26817006: Don't resolve private inherited members. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

index 8e409a9656d9a1c8b450a24c39a6515ba5d0f083..b8a1afb8337b64e53e9cbf4dfc87f2b8a103ec42 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

@@ -1864,7 +1864,7 @@ public class ElementResolver extends SimpleASTVisitor<Void> {

visitedInterfaces.add(targetClass);

if (includeTargetType) {

PropertyAccessorElement getter = targetType.getGetter(getterName);

- if (getter != null) {

+ if (getter != null && getter.isAccessibleIn(resolver.getDefiningLibrary())) {

return getter;

}

@@ -2090,7 +2090,7 @@ public class ElementResolver extends SimpleASTVisitor<Void> {

visitedInterfaces.add(targetClass);

if (includeTargetType) {

MethodElement method = targetType.getMethod(methodName);

- if (method != null) {

+ if (method != null && method.isAccessibleIn(resolver.getDefiningLibrary())) {

return method;

}

@@ -2173,7 +2173,7 @@ public class ElementResolver extends SimpleASTVisitor<Void> {

visitedInterfaces.add(targetClass);

if (includeTargetType) {

PropertyAccessorElement setter = targetType.getSetter(setterName);

- if (setter != null) {

+ if (setter != null && setter.isAccessibleIn(resolver.getDefiningLibrary())) {

return setter;

}