Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/kernel_to_il.cc

Issue 2681683005: [dart:io] Adds functions to set file access and modification time (Closed)
Patch Set: Fuchsia cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/io_service_no_ssl.h ('k') | sdk/lib/_internal/js_runtime/lib/io_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_to_il.cc
diff --git a/runtime/vm/kernel_to_il.cc b/runtime/vm/kernel_to_il.cc
index e1251535705c70a0680a041c6a93efe8cda51b43..984de1d4aeabf6f9dda81ac56c48f9fd6ca966c9 100644
--- a/runtime/vm/kernel_to_il.cc
+++ b/runtime/vm/kernel_to_il.cc
@@ -1811,11 +1811,11 @@ void ConstantEvaluator::VisitNot(Not* node) {
void ConstantEvaluator::VisitPropertyGet(PropertyGet* node) {
- const size_t kLengthLen = strlen("length");
+ const intptr_t kLengthLen = strlen("length");
zra 2017/02/08 17:24:21 This is to fix the standalone arm64 Android build.
String* string = node->name()->string();
- if (string->size() == kLengthLen &&
- memcmp(string->buffer(), "length", kLengthLen) == 0) {
+ if ((string->size() == kLengthLen) &&
+ (memcmp(string->buffer(), "length", kLengthLen) == 0)) {
node->receiver()->AcceptExpressionVisitor(this);
if (result_.IsString()) {
const dart::String& str =
« no previous file with comments | « runtime/bin/io_service_no_ssl.h ('k') | sdk/lib/_internal/js_runtime/lib/io_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698