[dart:io] Adds functions to set file access and modification time

[dart:io] Adds functions to set file access and modification time

fixes #27877

R=asiva@google.com, floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/3f5458cdcba21e694645a1733036c1739106208b

[zra, 2017-02-08 17:24:20]

zra@google.com changed reviewers:
+ asiva@google.com, bkonyi@google.com

[zra, 2017-02-08 17:24:21]

https://codereview.chromium.org/2681683005/diff/80001/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2681683005/diff/80001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:1814: const intptr_t kLengthLen = strlen("length");
This is to fix the standalone arm64 Android build.

[siva, 2017-02-08 21:18:28]

asiva@google.com changed reviewers:
+ lrn@google.com

[siva, 2017-02-08 21:18:29]

+lrn to review the Dart API changes

lgtm with one comment about access time.

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_andro...
File runtime/bin/file_android.cc (right):

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_andro...
runtime/bin/file_android.cc:479: times.modtime = millis /
kMillisecondsPerSecond;
When a file is modified doesn't it also mean it was accessed and so the access
time should also change?

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_fuchs...
File runtime/bin/file_fuchsia.cc (right):

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_fuchs...
runtime/bin/file_fuchsia.cc:451: times.actime = st.st_atime;
Ditto comment about access time.

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_linux.cc
File runtime/bin/file_linux.cc (right):

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_linux...
runtime/bin/file_linux.cc:485: times.actime = st.st_atime;
Ditto comment about access time here.

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_macos.cc
File runtime/bin/file_macos.cc (right):

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_macos...
runtime/bin/file_macos.cc:445: times.actime = st.st_atime;
ditto comment about access time here.

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_win.cc
File runtime/bin/file_win.cc (right):

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_win.c...
runtime/bin/file_win.cc:591: times.actime = st.st_atime;
ditto comment about access time here.

[zra, 2017-02-08 21:52:17]

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_andro...
File runtime/bin/file_android.cc (right):

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_andro...
runtime/bin/file_android.cc:479: times.modtime = millis /
kMillisecondsPerSecond;
On 2017/02/08 21:18:29, siva wrote:
> When a file is modified doesn't it also mean it was accessed and so the access
> time should also change?

According to: http://lists.gnu.org/archive/html/coreutils/2010-08/msg00010.html

"POSIX says that atime and mtime are user-settable to arbitrary times"

so I don't think we should try to do anything clever. There is a separate
timestamp on files that records when metadata is modified, which isn't
user-settable. I think that's available in FileStat, but we could add a
convenience method for it on File in another CL.

[Lasse Reichstein Nielsen, 2017-02-09 15:28:02]

lrn@google.com changed reviewers:
+ floitsch@google.com

[Lasse Reichstein Nielsen, 2017-02-09 15:28:04]

+floitsch - WDYT?

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/common.dart
File sdk/lib/io/common.dart (right):

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/common.dart...
sdk/lib/io/common.dart:29: return new ArgumentError("$message: $path");
I'm not sure this is really an argument error. 
On the other hand, as I read it, it only happens when someone sends a broken
request to the internal service, which shouldn't be able to happen. So it
probably doesn't matter what it does.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart
File sdk/lib/io/file.dart (right):

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:314: * [:Future<DateTime>:] that completes with a
[DateTime] object for the
Comment is badly formatted (because it predates the style guide).
Something like:

/**
 * Get the last-accessed time of the file.
 *
 * Returns the date and time where the file was last accessed, if the
information
 * is available.
 *  
 * Throws a [FileSystemException] if the operation fails.
 */

(I don't mention the future, it's obvious from the return type that the function
is asynchronous).
I assume this fails in the same way as the sync version, only through the
future.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:317: Future<DateTime> lastAccessed();
Feels like it should be a getter ... but there is an asynchronous setter
function corresponding to it, so it's probably best to be a function.

The sync version really should have been a getter/setter, but that's
inconsistent with lastModified(). Ack, failures of the past coming back to bite
us now :(

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:323: * Throws a [FileSystemException] if the operation
fails.
/**
 * Get the last-accessed time of the file.
 *
 * Blocks until the information is available.
 * Returns the date and time where the file was last accessed, 
 * if the information is available.
 *
 * Throws a [FileSystemException] if the operation fails.
 */

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:331: * [File] when the attributes have been set. If the
access time
attributes have -> time has
(there is only one attribute here, the time)

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:334: Future<File> setLastAccessed(DateTime time);
Just return Future, and complete with null.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:339: * If the attributes cannot be set, throws a
[FileSystemException].
attributes -> attribute (or just "time").

I'd prefer the sentence as:
* Throws a [FilsSystemException] if the time cannot be set.
It's always good to start paragraphs with "returns" or "throws" so it's easy to
find when you scan the docs.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:341: File setLastAccessedSync(DateTime time);
Return void.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:365: Future<File> setLastModified(DateTime time);
Just return a `Future` that is completed with `null`.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:372: File setLastModifiedSync(DateTime time);
Should just return void.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file_impl.d...
sdk/lib/io/file_impl.dart:398: Future<File> setLastAccessed(DateTime time) {
Future<File>->Future

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file_impl.d...
sdk/lib/io/file_impl.dart:407: return this;
return null;

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file_impl.d...
sdk/lib/io/file_impl.dart:413: File setLastAccessedSync(DateTime time) {
File->void

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file_impl.d...
sdk/lib/io/file_impl.dart:420: return this;
remove line.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file_impl.d...
sdk/lib/io/file_impl.dart:442: Future<File> setLastModified(DateTime time) {
As above.

https://codereview.chromium.org/2681683005/diff/100001/tests/standalone/io/fi...
File tests/standalone/io/file_test.dart (right):

https://codereview.chromium.org/2681683005/diff/100001/tests/standalone/io/fi...
tests/standalone/io/file_test.dart:1303: var accessed = new
File(Platform.executable).lastAccessedSync();
Are we sure this works on all platforms?

https://codereview.chromium.org/2681683005/diff/100001/tests/standalone/io/fi...
tests/standalone/io/file_test.dart:1336: Expect.isTrue(e is
FileSystemException);
You can use:
 Expect.throws(File(dirPath).lasAccessedSync,
               (e) => e is FileSystemException));
to test the throwing.
(You still need the finally for clean-up, though).

[floitsch, 2017-02-09 16:19:35]

Dart API LGTM.
I have a few nits/suggestions, but nothing major.
Thanks!

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart
File sdk/lib/io/file.dart (right):

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:314: * [:Future<DateTime>:] that completes with a
[DateTime] object for the
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> Comment is badly formatted (because it predates the style guide).
> Something like:
> 
> /**
>  * Get the last-accessed time of the file.
>  *
>  * Returns the date and time where the file was last accessed, if the
> information
>  * is available.
>  *  
>  * Throws a [FileSystemException] if the operation fails.
>  */
> 
> (I don't mention the future, it's obvious from the return type that the
function
> is asynchronous).
> I assume this fails in the same way as the sync version, only through the
> future.

Also, please use back-ticks for code: `Future<DateTime>`.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:317: Future<DateTime> lastAccessed();
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> Feels like it should be a getter ... but there is an asynchronous setter
> function corresponding to it, so it's probably best to be a function.
> 
> The sync version really should have been a getter/setter, but that's
> inconsistent with lastModified(). Ack, failures of the past coming back to
bite
> us now :(

It should still be a getter: `lastAccessed` is a field/getter name.
If it's preferable to keep the function, then it should change the name:
getLastAccessed, computeLastAccessed, ...

Edit: for consistency keep the function. I just saw that many others here are
also functions.
The IO library is unfortunately really bad in this respect. Not much we can do
now.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:323: * Throws a [FileSystemException] if the operation
fails.
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> /**
>  * Get the last-accessed time of the file.
>  *
>  * Blocks until the information is available.
>  * Returns the date and time where the file was last accessed, 
>  * if the information is available.
>  *
>  * Throws a [FileSystemException] if the operation fails.
>  */

Agree with Lasse:
As a general guideline: Start with a first short sentence that would be the
header in a dartdoc.

Start the sentence that talks about the return value with 'Returns'.

In addition to Lasse's change I would add a new line between the 'Throws' and
'Return' sentence, so that they are separate paragraphs in dartdoc.

Personally I find the return value more important and would put the 'Return'
sentence first.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:330: * Returns a [:Future<File>:] that completes with this
Please use `backticks` for code. The [:old_style:] is being phased out and
almost never used anymore.

(backticks have the advantage of being compatible with markdown).

[zra, 2017-02-09 17:21:39]

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_fuchs...
File runtime/bin/file_fuchsia.cc (right):

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_fuchs...
runtime/bin/file_fuchsia.cc:451: times.actime = st.st_atime;
On 2017/02/08 21:18:29, siva wrote:
> Ditto comment about access time.

Acknowledged.

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_linux.cc
File runtime/bin/file_linux.cc (right):

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_linux...
runtime/bin/file_linux.cc:485: times.actime = st.st_atime;
On 2017/02/08 21:18:29, siva wrote:
> Ditto comment about access time here.

Acknowledged.

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_macos.cc
File runtime/bin/file_macos.cc (right):

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_macos...
runtime/bin/file_macos.cc:445: times.actime = st.st_atime;
On 2017/02/08 21:18:29, siva wrote:
> ditto comment about access time here.

Acknowledged.

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_win.cc
File runtime/bin/file_win.cc (right):

https://codereview.chromium.org/2681683005/diff/100001/runtime/bin/file_win.c...
runtime/bin/file_win.cc:591: times.actime = st.st_atime;
On 2017/02/08 21:18:29, siva wrote:
> ditto comment about access time here.

Acknowledged.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/common.dart
File sdk/lib/io/common.dart (right):

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/common.dart...
sdk/lib/io/common.dart:29: return new ArgumentError("$message: $path");
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> I'm not sure this is really an argument error. 
> On the other hand, as I read it, it only happens when someone sends a broken
> request to the internal service, which shouldn't be able to happen. So it
> probably doesn't matter what it does.

Acknowledged.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart
File sdk/lib/io/file.dart (right):

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:314: * [:Future<DateTime>:] that completes with a
[DateTime] object for the
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> Comment is badly formatted (because it predates the style guide).
> Something like:
> 
> /**
>  * Get the last-accessed time of the file.
>  *
>  * Returns the date and time where the file was last accessed, if the
> information
>  * is available.
>  *  
>  * Throws a [FileSystemException] if the operation fails.
>  */
> 
> (I don't mention the future, it's obvious from the return type that the
function
> is asynchronous).
> I assume this fails in the same way as the sync version, only through the
> future.

Done.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:314: * [:Future<DateTime>:] that completes with a
[DateTime] object for the
On 2017/02/09 16:19:34, floitsch wrote:
> On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> > Comment is badly formatted (because it predates the style guide).
> > Something like:
> > 
> > /**
> >  * Get the last-accessed time of the file.
> >  *
> >  * Returns the date and time where the file was last accessed, if the
> > information
> >  * is available.
> >  *  
> >  * Throws a [FileSystemException] if the operation fails.
> >  */
> > 
> > (I don't mention the future, it's obvious from the return type that the
> function
> > is asynchronous).
> > I assume this fails in the same way as the sync version, only through the
> > future.
> 
> Also, please use back-ticks for code: `Future<DateTime>`.

Acknowledged.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:317: Future<DateTime> lastAccessed();
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> Feels like it should be a getter ... but there is an asynchronous setter
> function corresponding to it, so it's probably best to be a function.
> 
> The sync version really should have been a getter/setter, but that's
> inconsistent with lastModified(). Ack, failures of the past coming back to
bite
> us now :(

Acknowledged.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:317: Future<DateTime> lastAccessed();
On 2017/02/09 16:19:34, floitsch wrote:
> On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> > Feels like it should be a getter ... but there is an asynchronous setter
> > function corresponding to it, so it's probably best to be a function.
> > 
> > The sync version really should have been a getter/setter, but that's
> > inconsistent with lastModified(). Ack, failures of the past coming back to
> bite
> > us now :(
> 
> It should still be a getter: `lastAccessed` is a field/getter name.
> If it's preferable to keep the function, then it should change the name:
> getLastAccessed, computeLastAccessed, ...
> 
> Edit: for consistency keep the function. I just saw that many others here are
> also functions.
> The IO library is unfortunately really bad in this respect. Not much we can do
> now.

Acknowledged.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:323: * Throws a [FileSystemException] if the operation
fails.
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> /**
>  * Get the last-accessed time of the file.
>  *
>  * Blocks until the information is available.
>  * Returns the date and time where the file was last accessed, 
>  * if the information is available.
>  *
>  * Throws a [FileSystemException] if the operation fails.
>  */

Done.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:323: * Throws a [FileSystemException] if the operation
fails.
On 2017/02/09 16:19:35, floitsch wrote:
> On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> > /**
> >  * Get the last-accessed time of the file.
> >  *
> >  * Blocks until the information is available.
> >  * Returns the date and time where the file was last accessed, 
> >  * if the information is available.
> >  *
> >  * Throws a [FileSystemException] if the operation fails.
> >  */
> 
> Agree with Lasse:
> As a general guideline: Start with a first short sentence that would be the
> header in a dartdoc.
> 
> Start the sentence that talks about the return value with 'Returns'.
> 
> In addition to Lasse's change I would add a new line between the 'Throws' and
> 'Return' sentence, so that they are separate paragraphs in dartdoc.
> 
> Personally I find the return value more important and would put the 'Return'
> sentence first.

Acknowledged.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:330: * Returns a [:Future<File>:] that completes with this
On 2017/02/09 16:19:34, floitsch wrote:
> Please use `backticks` for code. The [:old_style:] is being phased out and
> almost never used anymore.
> 
> (backticks have the advantage of being compatible with markdown).

Replaced here and elsewhere.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:331: * [File] when the attributes have been set. If the
access time
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> attributes have -> time has
> (there is only one attribute here, the time)

Done.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:334: Future<File> setLastAccessed(DateTime time);
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> Just return Future, and complete with null.

Done.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:339: * If the attributes cannot be set, throws a
[FileSystemException].
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> attributes -> attribute (or just "time").
> 
> I'd prefer the sentence as:
> * Throws a [FilsSystemException] if the time cannot be set.
> It's always good to start paragraphs with "returns" or "throws" so it's easy
to
> find when you scan the docs.

Done.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:341: File setLastAccessedSync(DateTime time);
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> Return void.

Done.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:365: Future<File> setLastModified(DateTime time);
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> Just return a `Future` that is completed with `null`.
> 

Done.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file.dart#n...
sdk/lib/io/file.dart:372: File setLastModifiedSync(DateTime time);
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> Should just return void.

Done.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file_impl.d...
sdk/lib/io/file_impl.dart:398: Future<File> setLastAccessed(DateTime time) {
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> Future<File>->Future

Done.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file_impl.d...
sdk/lib/io/file_impl.dart:407: return this;
On 2017/02/09 15:28:04, Lasse Reichstein Nielsen wrote:
> return null;

Done.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file_impl.d...
sdk/lib/io/file_impl.dart:413: File setLastAccessedSync(DateTime time) {
On 2017/02/09 15:28:04, Lasse Reichstein Nielsen wrote:
> File->void

Done.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file_impl.d...
sdk/lib/io/file_impl.dart:420: return this;
On 2017/02/09 15:28:03, Lasse Reichstein Nielsen wrote:
> remove line.

Done.

https://codereview.chromium.org/2681683005/diff/100001/sdk/lib/io/file_impl.d...
sdk/lib/io/file_impl.dart:442: Future<File> setLastModified(DateTime time) {
On 2017/02/09 15:28:04, Lasse Reichstein Nielsen wrote:
> As above.

Done.

https://codereview.chromium.org/2681683005/diff/100001/tests/standalone/io/fi...
File tests/standalone/io/file_test.dart (right):

https://codereview.chromium.org/2681683005/diff/100001/tests/standalone/io/fi...
tests/standalone/io/file_test.dart:1303: var accessed = new
File(Platform.executable).lastAccessedSync();
On 2017/02/09 15:28:04, Lasse Reichstein Nielsen wrote:
> Are we sure this works on all platforms?

Tests pass on Linux/MacOS/Windows. Setting last accessed/modified time will fail
on some Android devices and succeed on others:

https://code.google.com/p/android/issues/detail?id=18624

Not sure we can do much there. The platform specific code builds for Fuchsia,
and we can request that it should work if it doesn't already.

https://codereview.chromium.org/2681683005/diff/100001/tests/standalone/io/fi...
tests/standalone/io/file_test.dart:1336: Expect.isTrue(e is
FileSystemException);
On 2017/02/09 15:28:04, Lasse Reichstein Nielsen wrote:
> You can use:
>  Expect.throws(File(dirPath).lasAccessedSync,
>                (e) => e is FileSystemException));
> to test the throwing.
> (You still need the finally for clean-up, though).

Leaving as-is for cleanup, and printing if it's the wrong exception.

[zra, 2017-02-09 17:45:29]

Description was changed from

==========
[dart:io] Adds functions to set file access and modification time

fixes #27877
==========

to

==========
[dart:io] Adds functions to set file access and modification time

fixes #27877

R=asiva@google.com, floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3f5458cdcba21e694645a1733036c1739106208b
==========

[zra, 2017-02-09 17:45:30]

Committed patchset #8 (id:140001) manually as
3f5458cdcba21e694645a1733036c1739106208b (presubmit successful).