Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2681653003: Create WATCHLIST to watch changes to subresource filtering. (Closed)

Created:
3 years, 10 months ago by engedy
Modified:
3 years, 10 months ago
Reviewers:
pkalinnikov
CC:
chromium-reviews, subresource-filter-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create WATCHLIST to watch changes to subresource filtering. Also add subresource-filter-reviews@ to this new watchlist. BUG=None Review-Url: https://codereview.chromium.org/2681653003 Cr-Commit-Position: refs/heads/master@{#448603} Committed: https://chromium.googlesource.com/chromium/src/+/e7b734da304387bdc790c50e47024698982c71a8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M WATCHLISTS View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
engedy
Pavel, could you please take a quick look?
3 years, 10 months ago (2017-02-07 10:51:49 UTC) #3
pkalinnikov
https://codereview.chromium.org/2681653003/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/2681653003/diff/1/WATCHLISTS#newcode914 WATCHLISTS:914: '|^chrome/browser/component_updater/subresource_filter_', I found some more places having files named ...
3 years, 10 months ago (2017-02-07 11:32:26 UTC) #4
engedy
https://codereview.chromium.org/2681653003/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/2681653003/diff/1/WATCHLISTS#newcode914 WATCHLISTS:914: '|^chrome/browser/component_updater/subresource_filter_', On 2017/02/07 11:32:25, pkalinnikov wrote: > I found ...
3 years, 10 months ago (2017-02-07 11:53:08 UTC) #7
pkalinnikov
LGTM.
3 years, 10 months ago (2017-02-07 11:54:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681653003/40001
3 years, 10 months ago (2017-02-07 11:54:41 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 12:08:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e7b734da304387bdc790c50e4702...

Powered by Google App Engine
This is Rietveld 408576698