Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 268163002: Let sync backup/rollback manager return a dummy encryption handler. (Closed)

Created:
6 years, 7 months ago by haitaol1
Modified:
6 years, 7 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Let sync backup/rollback manager return a dummy encryption handler. Backup/rollback doesn't require encryption while sync backend currently assumes there's an encryption handler ready to use. So use a dummy one to avoid crash. BUG=362679 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269147

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M sync/internal_api/sync_rollback_manager_base.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base.cc View 1 5 chunks +20 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
haitaol1
6 years, 7 months ago (2014-05-05 18:37:26 UTC) #1
Nicolas Zea
LGTM. And double checking, but we're not backing up passwords right?
6 years, 7 months ago (2014-05-06 18:57:57 UTC) #2
haitaol1
On 2014/05/06 18:57:57, Nicolas Zea wrote: > LGTM. And double checking, but we're not backing ...
6 years, 7 months ago (2014-05-06 20:50:49 UTC) #3
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 7 months ago (2014-05-07 20:04:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/268163002/20001
6 years, 7 months ago (2014-05-07 20:08:16 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 00:41:00 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #2). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 01:25:44 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 03:25:54 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 03:59:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium
6 years, 7 months ago (2014-05-08 03:59:00 UTC) #10
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 7 months ago (2014-05-08 17:07:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/268163002/20001
6 years, 7 months ago (2014-05-08 17:11:46 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 01:53:08 UTC) #13
Message was sent while issue was closed.
Change committed as 269147

Powered by Google App Engine
This is Rietveld 408576698