Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2655)

Unified Diff: ash/wm/workspace_controller_unittest.cc

Issue 2681613002: Avoid two targeting phases in aura client-lib and EventProcessor. (Closed)
Patch Set: test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/workspace_controller_unittest.cc
diff --git a/ash/wm/workspace_controller_unittest.cc b/ash/wm/workspace_controller_unittest.cc
index db4d5869762dff7e0340d9525b72602b0361871e..e51dedc49ee9bf00606cab60a79ce3511efd750e 100644
--- a/ash/wm/workspace_controller_unittest.cc
+++ b/ash/wm/workspace_controller_unittest.cc
@@ -1481,8 +1481,9 @@ TEST_F(WorkspaceControllerTest, WindowEdgeHitTest) {
ParentWindowInPrimaryRootWindow(second.get());
second->Show();
- ui::EventTarget* root = first->GetRootWindow();
- ui::EventTargeter* targeter = root->GetEventTargeter();
+ aura::Window* root = first->GetRootWindow();
+ ui::EventTargeter* targeter =
+ root->GetHost()->dispatcher()->GetDefaultEventTargeter();
// The windows overlap, and |second| is on top of |first|. Events targeted
// slightly outside the edges of the |second| window should still be targeted
@@ -1530,8 +1531,9 @@ TEST_F(WorkspaceControllerTest, WindowEdgeMouseHitTestPanel) {
aura::test::TestWindowDelegate delegate;
std::unique_ptr<Window> window(
CreateTestPanel(&delegate, gfx::Rect(20, 10, 100, 50)));
- ui::EventTarget* root = window->GetRootWindow();
- ui::EventTargeter* targeter = root->GetEventTargeter();
+ aura::Window* root = window->GetRootWindow();
+ ui::EventTargeter* targeter =
+ root->GetHost()->dispatcher()->GetDefaultEventTargeter();
const gfx::Rect bounds = window->bounds();
const int kNumPoints = 5;
struct {
@@ -1566,8 +1568,9 @@ TEST_F(WorkspaceControllerTest, WindowEdgeTouchHitTestPanel) {
aura::test::TestWindowDelegate delegate;
std::unique_ptr<Window> window(
CreateTestPanel(&delegate, gfx::Rect(20, 10, 100, 50)));
- ui::EventTarget* root = window->GetRootWindow();
- ui::EventTargeter* targeter = root->GetEventTargeter();
+ aura::Window* root = window->GetRootWindow();
+ ui::EventTargeter* targeter =
+ root->GetHost()->dispatcher()->GetDefaultEventTargeter();
const gfx::Rect bounds = window->bounds();
const int kNumPoints = 5;
struct {
@@ -1607,8 +1610,9 @@ TEST_F(WorkspaceControllerTest, WindowEdgeHitTestDocked) {
window->GetRootWindow(), kShellWindowId_DockedContainer);
docked_container->AddChild(window.get());
window->Show();
- ui::EventTarget* root = window->GetRootWindow();
- ui::EventTargeter* targeter = root->GetEventTargeter();
+ aura::Window* root = window->GetRootWindow();
+ ui::EventTargeter* targeter =
+ root->GetHost()->dispatcher()->GetDefaultEventTargeter();
const gfx::Rect bounds = window->bounds();
const int kNumPoints = 5;
struct {

Powered by Google App Engine
This is Rietveld 408576698