Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: ui/aura/mus/window_tree_client.cc

Issue 2681613002: Avoid two targeting phases in aura client-lib and EventProcessor. (Closed)
Patch Set: nits and tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/mus/window_tree_client.cc
diff --git a/ui/aura/mus/window_tree_client.cc b/ui/aura/mus/window_tree_client.cc
index ec6baf2c07d166cdac5c86ca8da39c8cadd9ecaf..a94191e3e868543adfdb3a8d2de6ab8613bec4e2 100644
--- a/ui/aura/mus/window_tree_client.cc
+++ b/ui/aura/mus/window_tree_client.cc
@@ -160,6 +160,14 @@ void ConvertEventLocationToDip(int64_t display_id, ui::LocatedEvent* event) {
event->set_root_location(root_location);
}
+// Set the |target| to be the target window of this |event| and send it to
+// the EventProcessor.
+void DispatchEventToTarget(ui::Event* event, WindowMus* target) {
+ ui::Event::DispatcherApi dispatch_helper(event);
+ dispatch_helper.set_target(target->GetWindow());
+ GetWindowTreeHostMus(target)->SendEventToProcessor(event);
+}
+
} // namespace
WindowTreeClient::WindowTreeClient(
@@ -1165,31 +1173,22 @@ void WindowTreeClient::OnWindowInputEvent(uint32_t event_id,
WindowTreeHostMus* host = GetWindowTreeHostMus(window);
DCHECK(host);
sadrul 2017/02/14 21:40:10 |host| is no longer used I think? Remove.
riajiang 2017/02/15 18:09:27 True. Done.
- // The location of the event is relative to |window|. As the event is handed
- // to WindowTreeHost we need it to be relative to WindowTreeHost.
- if (event->IsLocatedEvent()) {
- gfx::Point host_location = event->AsLocatedEvent()->location();
- aura::Window::ConvertPointToTarget(window->GetWindow(), host->window(),
- &host_location);
- event->AsLocatedEvent()->set_location(host_location);
- }
-
EventAckHandler ack_handler(CreateEventResultCallback(event_id));
// TODO(moshayedi): crbug.com/617222. No need to convert to ui::MouseEvent or
// ui::TouchEvent once we have proper support for pointer events.
if (event->IsMousePointerEvent()) {
if (event->type() == ui::ET_POINTER_WHEEL_CHANGED) {
ui::MouseWheelEvent mapped_event(*event->AsPointerEvent());
- host->SendEventToProcessor(&mapped_event);
+ DispatchEventToTarget(&mapped_event, window);
} else {
ui::MouseEvent mapped_event(*event->AsPointerEvent());
- host->SendEventToProcessor(&mapped_event);
+ DispatchEventToTarget(&mapped_event, window);
}
} else if (event->IsTouchPointerEvent()) {
ui::TouchEvent mapped_event(*event->AsPointerEvent());
- host->SendEventToProcessor(&mapped_event);
+ DispatchEventToTarget(&mapped_event, window);
} else {
- host->SendEventToProcessor(event.get());
+ DispatchEventToTarget(event.get(), window);
}
ack_handler.set_handled(event->handled());
}

Powered by Google App Engine
This is Rietveld 408576698