Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: ui/events/event_processor.cc

Issue 2681613002: Avoid two targeting phases in aura client-lib and EventProcessor. (Closed)
Patch Set: early return Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/events/event_processor.h ('k') | ui/events/event_processor_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/events/event_processor.h" 5 #include "ui/events/event_processor.h"
6 6
7 #include "ui/events/event_target.h" 7 #include "ui/events/event_target.h"
8 #include "ui/events/event_targeter.h" 8 #include "ui/events/event_targeter.h"
9 9
10 namespace ui { 10 namespace ui {
11 11
12 EventDispatchDetails EventProcessor::OnEventFromSource(Event* event) { 12 EventDispatchDetails EventProcessor::OnEventFromSource(Event* event) {
13 EventTarget* root = GetRootTarget();
14 CHECK(root);
15 EventTargeter* targeter = root->GetEventTargeter();
16 CHECK(targeter);
17
18 // If |event| is in the process of being dispatched or has already been 13 // If |event| is in the process of being dispatched or has already been
19 // dispatched, then dispatch a copy of the event instead. 14 // dispatched, then dispatch a copy of the event instead. We expect event
15 // target to be already set if event phase is after EP_PREDISPATCH.
20 bool dispatch_original_event = event->phase() == EP_PREDISPATCH; 16 bool dispatch_original_event = event->phase() == EP_PREDISPATCH;
17 DCHECK(dispatch_original_event || event->target());
21 Event* event_to_dispatch = event; 18 Event* event_to_dispatch = event;
22 std::unique_ptr<Event> event_copy; 19 std::unique_ptr<Event> event_copy;
23 if (!dispatch_original_event) { 20 if (!dispatch_original_event) {
24 event_copy = Event::Clone(*event); 21 event_copy = Event::Clone(*event);
25 event_to_dispatch = event_copy.get(); 22 event_to_dispatch = event_copy.get();
26 } 23 }
27 24
28 OnEventProcessingStarted(event_to_dispatch); 25 OnEventProcessingStarted(event_to_dispatch);
29 EventTarget* target = NULL; 26 EventTarget* target = nullptr;
30 if (!event_to_dispatch->handled()) 27 EventTargeter* targeter = nullptr;
31 target = targeter->FindTargetForEvent(root, event_to_dispatch); 28 if (!event_to_dispatch->handled()) {
29 EventTarget* root = GetRootForEvent(event_to_dispatch);
30 DCHECK(root);
31 targeter = root->GetEventTargeter();
32 if (targeter) {
33 target = targeter->FindTargetForEvent(root, event_to_dispatch);
34 } else {
35 targeter = GetDefaultEventTargeter();
36 if (event_to_dispatch->target())
37 target = root;
38 else
39 target = targeter->FindTargetForEvent(root, event_to_dispatch);
40 }
41 DCHECK(targeter);
42 }
32 43
33 EventDispatchDetails details; 44 EventDispatchDetails details;
34 while (target) { 45 while (target) {
35 details = DispatchEvent(target, event_to_dispatch); 46 details = DispatchEvent(target, event_to_dispatch);
36 47
37 if (!dispatch_original_event) { 48 if (!dispatch_original_event) {
38 if (event_to_dispatch->stopped_propagation()) 49 if (event_to_dispatch->stopped_propagation())
39 event->StopPropagation(); 50 event->StopPropagation();
40 else if (event_to_dispatch->handled()) 51 else if (event_to_dispatch->handled())
41 event->SetHandled(); 52 event->SetHandled();
(...skipping 12 matching lines...) Expand all
54 return details; 65 return details;
55 } 66 }
56 67
57 void EventProcessor::OnEventProcessingStarted(Event* event) { 68 void EventProcessor::OnEventProcessingStarted(Event* event) {
58 } 69 }
59 70
60 void EventProcessor::OnEventProcessingFinished(Event* event) { 71 void EventProcessor::OnEventProcessingFinished(Event* event) {
61 } 72 }
62 73
63 } // namespace ui 74 } // namespace ui
OLDNEW
« no previous file with comments | « ui/events/event_processor.h ('k') | ui/events/event_processor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698