Avoid two targeting phases in aura client-lib and EventProcessor.

ui/aura/window_event_dispatcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/window_event_dispatcher.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
 #include "ui/aura/client/capture_client.h"
 #include "ui/aura/client/cursor_client.h"
 #include "ui/aura/client/event_client.h"
 #include "ui/aura/client/focus_client.h"
 #include "ui/aura/client/screen_position_client.h"
 #include "ui/aura/env.h"
 #include "ui/aura/env_input_state_controller.h"
 #include "ui/aura/mus/mus_mouse_location_updater.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_delegate.h"
 #include "ui/aura/window_targeter.h"
 #include "ui/aura/window_tracker.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/base/hit_test.h"
 #include "ui/compositor/dip_util.h"
 #include "ui/events/event.h"
+#include "ui/events/event_targeter.h"
 #include "ui/events/event_utils.h"
 #include "ui/events/gestures/gesture_recognizer.h"
 #include "ui/events/gestures/gesture_types.h"
 
 typedef ui::EventDispatchDetails DispatchDetails;
 
 namespace aura {
 
 namespace {
 
@@ skipping 33 matching lines @@
       old_dispatch_target_(NULL),
       synthesize_mouse_move_(false),
       move_hold_count_(0),
       dispatching_held_event_(nullptr),
       observer_manager_(this),
       env_controller_(new EnvInputStateController),
       repost_event_factory_(this),
       held_event_factory_(this) {
   ui::GestureRecognizer::Get()->AddGestureEventHelper(this);
   Env::GetInstance()->AddObserver(this);
-  if (Env::GetInstance()->mode() == Env::Mode::MUS)
+  if (Env::GetInstance()->mode() == Env::Mode::MUS) {
     mus_mouse_location_updater_ = base::MakeUnique<MusMouseLocationUpdater>();
+    event_targeter_ = base::MakeUnique<WindowTargeter>();
+  }
 }
 
 WindowEventDispatcher::~WindowEventDispatcher() {
   TRACE_EVENT0("shutdown", "WindowEventDispatcher::Destructor");
   Env::GetInstance()->RemoveObserver(this);
   ui::GestureRecognizer::Get()->RemoveGestureEventHelper(this);
 }
 
 void WindowEventDispatcher::RepostEvent(const ui::LocatedEvent* event) {
   DCHECK(event->type() == ui::ET_MOUSE_PRESSED ||
@@ skipping 314 matching lines @@
 void WindowEventDispatcher::SetNativeCapture() {
   host_->SetCapture();
 }
 
 void WindowEventDispatcher::ReleaseNativeCapture() {
   host_->ReleaseCapture();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // WindowEventDispatcher, ui::EventProcessor implementation:
-ui::EventTarget* WindowEventDispatcher::GetRootTarget() {
-  return window();
+ui::EventTarget* WindowEventDispatcher::GetRootForEvent(ui::Event* event) {
+  if (Env::GetInstance()->mode() == Env::Mode::LOCAL)
+    return window();
+
+  if (!event->target())
+    return window();
+
+  ui::EventTarget* target = event->target();

[sky, 2017/02/15 20:47:17]

Using ui::EventTarget rather the Window makes this code slightly more confusing.
Given we know the target is a window, can you use Window* here rather than
ui::EventTarget? This means you won't need the casts below.

[riajiang, 2017/02/16 00:34:08]

This function returns ui::EventTarget so I think maybe we can keep using
EventTarget and only cast when it's Window related functions
(Window::ConvertPointToTarget)? We also want to use GetEventTargeter and
GetParentTarget for the EventTarget which would require a cast if it's a Window?

[sky, 2017/02/16 01:03:02]

Ugh! This is one of those places made painful by making the implementation of
the interface private. I would find this code easier to read if it were:

for (aura::Window* ancestor = target->parent(); ancestor; ancestor =
ancestor->parent()) {
*  if (ancestor->GetEventTarget()) ...
}

But * fails because the implementation of GetEventTarget is private.

This is made more awkward because you compare ancestor_with_targeter (an
EventTarger) to window() (an aura::Window). ui::EventTarget *has* to be the
aura::Window.

*SIGH*

Ok, leave what you have.

+  ui::EventTarget* ancestor_with_targeter = target;
+  for (ui::EventTarget* ancestor = target->GetParentTarget(); ancestor;
+       ancestor = ancestor->GetParentTarget()) {
+    if (ancestor->GetEventTargeter())
+      ancestor_with_targeter = ancestor;
+    if (ancestor == window())

[sky, 2017/02/16 01:03:02]

Is this check really necessary?

[riajiang, 2017/02/16 19:10:35]

Because GetParentTarget() will go all the way up to ash::Shell and aura::Env
(which have NOTREACHED in GetEventTargeter) but we only wanted to walk up to the
root widow?

+      break;
+  }
+
+  if (ancestor_with_targeter != target && event->IsLocatedEvent()) {
+    gfx::Point location = event->AsLocatedEvent()->location();
+    gfx::Point root_location = event->AsLocatedEvent()->root_location();
+    Window::ConvertPointToTarget(static_cast<Window*>(target),
+                                 static_cast<Window*>(ancestor_with_targeter),
+                                 &location);
+    Window::ConvertPointToTarget(static_cast<Window*>(target),
+                                 static_cast<Window*>(ancestor_with_targeter),
+                                 &root_location);
+    event->AsLocatedEvent()->set_location(location);
+    event->AsLocatedEvent()->set_root_location(root_location);
+  }
+  return ancestor_with_targeter;
+}
+
+ui::EventTargeter* WindowEventDispatcher::GetDefaultEventTargeter() {
+  return event_targeter_.get();
 }
 
 void WindowEventDispatcher::OnEventProcessingStarted(ui::Event* event) {
   // The held events are already in |window()|'s coordinate system. So it is
   // not necessary to apply the transform to convert from the host's
   // coordinate system to |window()|'s coordinate system.
   if (event->IsLocatedEvent() && !is_dispatched_held_event(*event))
     TransformEventForDeviceScaleFactor(static_cast<ui::LocatedEvent*>(event));
 
   if (mus_mouse_location_updater_)
@@ skipping 439 matching lines @@
   }
 
   // This flag is set depending on the gestures recognized in the call above,
   // and needs to propagate with the forwarded event.
   event->set_may_cause_scrolling(orig_event.may_cause_scrolling());
 
   return PreDispatchLocatedEvent(target, event);
 }
 
 }  // namespace aura