Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: ui/events/event_processor.h

Issue 2681613002: Avoid two targeting phases in aura client-lib and EventProcessor. (Closed)
Patch Set: nits and tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_EVENTS_EVENT_PROCESSOR_H_ 5 #ifndef UI_EVENTS_EVENT_PROCESSOR_H_
6 #define UI_EVENTS_EVENT_PROCESSOR_H_ 6 #define UI_EVENTS_EVENT_PROCESSOR_H_
7 7
8 #include "ui/events/event_dispatcher.h" 8 #include "ui/events/event_dispatcher.h"
9 #include "ui/events/event_source.h" 9 #include "ui/events/event_source.h"
10 10
11 namespace ui { 11 namespace ui {
12 12
13 class EventTargeter;
14
13 // EventProcessor receives an event from an EventSource and dispatches it to a 15 // EventProcessor receives an event from an EventSource and dispatches it to a
14 // tree of EventTargets. 16 // tree of EventTargets.
15 class EVENTS_EXPORT EventProcessor : public EventDispatcherDelegate { 17 class EVENTS_EXPORT EventProcessor : public EventDispatcherDelegate {
16 public: 18 public:
17 ~EventProcessor() override {} 19 ~EventProcessor() override {}
18 20
19 // Returns the root of the tree this event processor owns. 21 // Returns the EventTarget with the right EventTargeter that we should use for
20 virtual EventTarget* GetRootTarget() = 0; 22 // dispatching this |event|.
23 virtual EventTarget* GetRootForEvent(Event* event) = 0;
24
25 // If the root target returned by GetRootForEvent() does not have a
26 // targeter set, then the default targeter is used to find the target.
27 virtual EventTargeter* GetDefaultEventTargeter() = 0;
21 28
22 // Dispatches an event received from the EventSource to the tree of 29 // Dispatches an event received from the EventSource to the tree of
23 // EventTargets (whose root is returned by GetRootTarget()). The co-ordinate 30 // EventTargets (whose root is returned by GetRootTarget()). The co-ordinate
24 // space of the source must be the same as the root target, except that the 31 // space of the source must be the same as the root target, except that the
25 // target may have a high-dpi scale applied. 32 // target may have a high-dpi scale applied.
26 // TODO(tdanderson|sadrul): This is only virtual for testing purposes. It 33 // TODO(tdanderson|sadrul): This is only virtual for testing purposes. It
27 // should not be virtual at all. 34 // should not be virtual at all.
28 virtual EventDispatchDetails OnEventFromSource(Event* event) 35 virtual EventDispatchDetails OnEventFromSource(Event* event)
29 WARN_UNUSED_RESULT; 36 WARN_UNUSED_RESULT;
30 37
31 protected: 38 protected:
32 // Invoked at the start of processing, before an EventTargeter is used to 39 // Invoked at the start of processing, before an EventTargeter is used to
33 // find the target of the event. If processing should not take place, marks 40 // find the target of the event. If processing should not take place, marks
34 // |event| as handled. Otherwise updates |event| so that the targeter can 41 // |event| as handled. Otherwise updates |event| so that the targeter can
35 // operate correctly (e.g., it can be used to update the location of the 42 // operate correctly (e.g., it can be used to update the location of the
36 // event when dispatching from an EventSource in high-DPI) and updates any 43 // event when dispatching from an EventSource in high-DPI) and updates any
37 // members in the event processor as necessary. 44 // members in the event processor as necessary.
38 virtual void OnEventProcessingStarted(Event* event); 45 virtual void OnEventProcessingStarted(Event* event);
39 46
40 // Invoked when the processing of |event| has finished (i.e., when no further 47 // Invoked when the processing of |event| has finished (i.e., when no further
41 // dispatching of |event| will be performed by this EventProcessor). Note 48 // dispatching of |event| will be performed by this EventProcessor). Note
42 // that the last target to which |event| was dispatched may have been 49 // that the last target to which |event| was dispatched may have been
43 // destroyed. 50 // destroyed.
44 virtual void OnEventProcessingFinished(Event* event); 51 virtual void OnEventProcessingFinished(Event* event);
45 }; 52 };
46 53
47 } // namespace ui 54 } // namespace ui
48 55
49 #endif // UI_EVENTS_EVENT_PROCESSOR_H_ 56 #endif // UI_EVENTS_EVENT_PROCESSOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698