Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: pkg/analysis_server/test/integration/analysis/get_errors_test.dart

Issue 2681493002: [Gardening] Remove an invalid (and flaky) test (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/analysis/get_errors_test.dart
diff --git a/pkg/analysis_server/test/integration/analysis/get_errors.dart b/pkg/analysis_server/test/integration/analysis/get_errors_test.dart
similarity index 63%
rename from pkg/analysis_server/test/integration/analysis/get_errors.dart
rename to pkg/analysis_server/test/integration/analysis/get_errors_test.dart
index d7aee3c4edfdf19f7ac6f55a64ba85e5f716706d..ce66f0569bf2d5122c9ba7d02f4682c0c8bfe534 100644
--- a/pkg/analysis_server/test/integration/analysis/get_errors.dart
+++ b/pkg/analysis_server/test/integration/analysis/get_errors_test.dart
@@ -7,21 +7,23 @@ library test.integration.analysis.get.errors;
import 'dart:async';
import 'package:test/test.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
import '../integration_tests.dart';
+main() {
+ defineReflectiveSuite(() {
+ defineReflectiveTests(GetErrorsTest);
+ defineReflectiveTests(GetErrorsTest_Driver);
+ });
+}
+
/**
* Base class for testing the "analysis.getErrors" request.
*/
class AnalysisDomainGetErrorsTest
extends AbstractAnalysisServerIntegrationTest {
- /**
- * True if the "analysis.getErrors" request should be made after analysis is
- * complete.
- */
- final bool afterAnalysis;
-
- AnalysisDomainGetErrorsTest(this.afterAnalysis);
+ AnalysisDomainGetErrorsTest();
test_getErrors() {
String pathname = sourcePath('test.dart');
@@ -36,10 +38,16 @@ main() {
expect(result.errors, equals(currentAnalysisErrors[pathname]));
});
}
- if (afterAnalysis) {
- return analysisFinished.then((_) => finishTest());
- } else {
- return finishTest();
- }
+
+ return analysisFinished.then((_) => finishTest());
}
}
+
+@reflectiveTest
+class GetErrorsTest extends AnalysisDomainGetErrorsTest {}
+
+@reflectiveTest
+class GetErrorsTest_Driver extends AnalysisDomainGetErrorsTest {
+ @override
+ bool get enableNewAnalysisDriver => true;
+}

Powered by Google App Engine
This is Rietveld 408576698