Issue 2681483002: NQE: Do not record correlation if metric is missing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2681483002: NQE: Do not record correlation if metric is missing (Closed)

Created:
3 years, 10 months ago by tbansal1

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

More Reviews

Description

NQE: Do not record correlation if metric is missing In Network Quality Estimator (NQE), do not record the correlation metric if any of the underlying metric is unavailable. Also, do not record the correlation metric if there was a connection change recently. These changes ensure that the metric is recorded only when valid values were available. BUG=688198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2668403003 Cr-Commit-Position: refs/heads/master@{#448032} (cherry picked from commit 10d16356dad16ba47a8b708d45aad2f291dabfff)

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -18 lines)			Patch
	M	net/nqe/network_quality_estimator.cc	View		1 chunk	+22 lines, -18 lines	0 comments	Download
	M	net/nqe/network_quality_estimator_unittest.cc	View		2 chunks	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tbansal1

3 years, 10 months ago (2017-02-06 18:17:38 UTC) #1

Description was changed from

==========
NQE: Do not record correlation if metric is missing

In Network Quality Estimator (NQE), do not record the correlation
metric if any of the underlying metric is unavailable. Also, do not
record the correlation metric if there was a connection change
recently. These changes ensure that the metric is recorded only when
valid values were available.

BUG=688198
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2668403003
Cr-Commit-Position: refs/heads/master@{#448032}
(cherry picked from commit 10d16356dad16ba47a8b708d45aad2f291dabfff)
==========

to

==========
NQE: Do not record correlation if metric is missing

In Network Quality Estimator (NQE), do not record the correlation
metric if any of the underlying metric is unavailable. Also, do not
record the correlation metric if there was a connection change
recently. These changes ensure that the metric is recorded only when
valid values were available.

BUG=688198
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2668403003
Cr-Commit-Position: refs/heads/master@{#448032}
(cherry picked from commit 10d16356dad16ba47a8b708d45aad2f291dabfff)
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages