Fix a recent regression in IME inside OOPIFs

chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chrome_content_browser_client.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 774 matching lines @@
   for (size_t i = 0; i < views.size(); ++i) {
     // First focus the <input>.
     send_tab_and_wait_for_value(values[i]);
 
     // Send a sequence of |count| 'E' keys and wait until the view receives a
     // selection change update for a text of the corresponding size, |count|.
     send_keys_select_all_wait_for_selection_change(views[i], count++);
   }
 }
 
+// This test verifies that commit text by sending the IPC works for all frames

[alexmos, 2017/02/08 02:16:23]

nit: commit text -> committing text?

[EhsanK, 2017/02/08 02:35:49]

Acknowledged.

+// on the page. Specifically, the test commits given text to a frame which
+// current has focus and a focused <input> and then verifies that the <input>

[alexmos, 2017/02/08 02:16:23]

nit: s/current/currently/

[EhsanK, 2017/02/08 02:35:49]

Acknowledged. I redid this paragraph. Sorry for the many typos.

+// value equals to the text to commit.

[alexmos, 2017/02/08 02:16:23]

Might be useful to reference https://crbug.com/688842.

[EhsanK, 2017/02/08 02:35:49]

Acknowledged.

+IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
+                       ImeCommitTextForAllFrames) {
+  CreateIframePage("a(b,c(a))");
+  std::vector<content::RenderFrameHost*> frames{
+      GetFrame(IndexVector{}), GetFrame(IndexVector{0}),
+      GetFrame(IndexVector{1}), GetFrame(IndexVector{1, 0})};
+  for (size_t i = 0; i < frames.size(); ++i)
+    AddInputFieldToFrame(frames[i], "text", "", true);
+
+  auto focus_input_in_frame = [](content::RenderFrameHost* frame) {
+    EXPECT_TRUE(ExecuteScript(
+        frame, "window.focus(); document.querySelector('input').focus();"));
+  };
+
+  auto get_input_value_from_frame = [](content::RenderFrameHost* frame) {
+    std::string result;
+    EXPECT_TRUE(ExecuteScriptAndExtractString(frame,
+                                              "window.domAutomationController."
+                                              "send(document.querySelector('"
+                                              "input').value);",
+                                              &result));
+    return result;
+  };
+
+  std::string sample_text[4] = {"main", "child_b", "child_c", "child_a"};
+
+  for (size_t index = 0; index < 1U; ++index) {

[alexmos, 2017/02/08 02:16:23]

Should 1U be frames.size() instead?

[EhsanK, 2017/02/08 02:35:49]

Yes. good catch! left over from testing my test :).

+    // Focus the frame and the <input> inside it.
+    focus_input_in_frame(frames[index]);
+
+    // Commit some text.
+    content::SendImeCommitTextToWidget(
+        frames[index]->GetView()->GetRenderWidgetHost(),
+        base::UTF8ToUTF16(sample_text[index]),
+        std::vector<ui::CompositionUnderline>(), gfx::Range(), 0);
+
+    // Running a NOP js code to make sure the <input> text is updated.
+    EXPECT_TRUE(ExecuteScript(frames[index], "var nop = true;"));
+
+    // Query <input>.value and make sure it matches the text we sent to commit.
+    EXPECT_EQ(sample_text[index], get_input_value_from_frame(frames[index]));
+  }
+}
+
 // TODO(ekaramad): Some of the following tests should be active on Android as
 // well. Enable them when the corresponding feature is implemented for Android
 // (https://crbug.com/602723).
 #if !defined(OS_ANDROID)
 // This test creates a page with multiple child frames and adds an <input> to
 // each frame. Then, sequentially, each <input> is focused by sending a tab key.
 // Then, after |TextInputState.type| for a view is changed to text, another key
 // is pressed (a character) and then the test verifies that TextInputManager
 // receives the corresponding update on the change in selection bounds on the
 // browser side.
@@ skipping 549 matching lines @@
 
   // Closing this WebContents while we still hold on to our TestBrowserClient.
   EXPECT_TRUE(browser()->tab_strip_model()->CloseWebContentsAt(
       1, TabStripModel::CLOSE_USER_GESTURE));
 
   // For the cleanup of the original WebContents in tab index 0.
   content::SetBrowserClientForTesting(old_browser_client);
 }
 #endif  //  defined(MAC_OSX)
 #endif  // !defined(OS_ANDROID)