chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm - Issue 268143007: Simplify ExtensionPopup widget closing behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

Issue 268143007: Simplify ExtensionPopup widget closing behavior. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove redundant TOOLKIT_VIEWS pre-processor conditions; fix Mac. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

diff --git a/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm b/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

index 4a0c51b094e60f70c2026453769b0b5349003722..d43809912c51d1243e0afb730203e5d1bccd143a 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

+++ b/chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

@@ -59,6 +59,10 @@ std::string BrowserActionTestUtil::GetTooltip(int index) {

return base::SysNSStringToUTF8(tooltip);

}

+gfx::NativeView BrowserActionTestUtil::GetPopupNativeView() {

+ return [[ExtensionPopupController popup] view];

bool BrowserActionTestUtil::HasPopup() {

return [ExtensionPopupController popup] != nil;

}