Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8425)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc

Issue 2681413002: MD Settings: Disable MdSettingsUITest.ViewSourceDoesntCrash when Vulcanized. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc b/chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc
index 9a1967620d547831024d9d162af9048968728de6..fcd00870867749c73b709284bc8798daf7cece52 100644
--- a/chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc
@@ -23,11 +23,15 @@ typedef InProcessBrowserTest MdSettingsUITest;
using ui_test_utils::NavigateToURL;
using content::WaitForLoadStop;
+// When using Vulcanize, this test times out, probably because the HTML and JS
+// bundled files are too large.
+#if !BUILDFLAG(USE_VULCANIZE)
IN_PROC_BROWSER_TEST_F(MdSettingsUITest, ViewSourceDoesntCrash) {
NavigateToURL(browser(),
GURL(content::kViewSourceScheme + std::string(":") +
chrome::kChromeUIMdSettingsURL));
Dan Beam 2017/02/09 20:32:56 fwiw: you could also just try to load something sm
dpapad 2017/02/09 23:41:25 Done.
}
+#endif
// May not complete on memory and Windows debug bots. TODO(dbeam): investigate
// and fix. See https://crbug.com/558434, https://crbug.com/620370 and
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698