Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: ios/chrome/common/BUILD.gn

Issue 2681353002: [ObjC ARC] Converts ios/chrome/common:unit_tests to ARC. (Closed)
Patch Set: extract class that does not make sense to be formatted to own target Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/common/ns_regular_expression_unittest.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/ios/ios_sdk.gni") 6 import("//build/config/ios/ios_sdk.gni")
7 7
8 source_set("common") { 8 source_set("common") {
9 sources = [ 9 sources = [
10 "channel_info.h", 10 "channel_info.h",
(...skipping 11 matching lines...) Expand all
22 "//components/version_info", 22 "//components/version_info",
23 "//ios/chrome/common/app_group:main_app", 23 "//ios/chrome/common/app_group:main_app",
24 "//ios/chrome/common/physical_web", 24 "//ios/chrome/common/physical_web",
25 "//net", 25 "//net",
26 "//url", 26 "//url",
27 ] 27 ]
28 28
29 libs = [ "QuartzCore.framework" ] 29 libs = [ "QuartzCore.framework" ]
30 } 30 }
31 31
32 source_set("unit_tests") { 32 source_set("noarc_unit_tests") {
sdefresne 2017/02/10 15:36:36 Can you add a comment there says that this test sh
lody 2017/02/13 10:25:38 Done.
33 testonly = true 33 testonly = true
34 sources = [ 34 sources = [
35 "block_unittest.mm", 35 "block_unittest.mm",
36 ]
37 deps = [
38 ":common",
39 "//base",
40 "//testing/gtest",
41 ]
42 }
43
44 source_set("unit_tests") {
45 configs += [ "//build/config/compiler:enable_arc" ]
46 testonly = true
47 sources = [
36 "ns_regular_expression_unittest.mm", 48 "ns_regular_expression_unittest.mm",
37 "string_util_unittest.mm", 49 "string_util_unittest.mm",
38 "x_callback_url_unittest.cc", 50 "x_callback_url_unittest.cc",
39 ] 51 ]
40 deps = [ 52 deps = [
41 ":common", 53 ":common",
42 "//base", 54 "//base",
43 "//testing/gtest", 55 "//testing/gtest",
44 ] 56 ]
45 } 57 }
46 58
47 buildflag_header("ios_app_bundle_id_prefix_header") { 59 buildflag_header("ios_app_bundle_id_prefix_header") {
48 header = "ios_app_bundle_id_prefix.h" 60 header = "ios_app_bundle_id_prefix.h"
49 flags = [ "IOS_APP_BUNDLE_ID_PREFIX=\"$ios_app_bundle_id_prefix\"" ] 61 flags = [ "IOS_APP_BUNDLE_ID_PREFIX=\"$ios_app_bundle_id_prefix\"" ]
50 } 62 }
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/common/ns_regular_expression_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698