Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/lifetime/browser_close_manager.cc

Issue 2681203002: Add Browser::SkipCallBeforeUnload so that the browser windows can be closed regardless of beforeunl… (Closed)
Patch Set: rebase from master Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_manager.cc » ('j') | chrome/browser/ui/browser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/lifetime/browser_close_manager.cc
diff --git a/chrome/browser/lifetime/browser_close_manager.cc b/chrome/browser/lifetime/browser_close_manager.cc
index 2a32c3c638fd84ecb4db5669acc6439924feea3b..fa3043665d865ad964d6628093dfb54c782b7ba3 100644
--- a/chrome/browser/lifetime/browser_close_manager.cc
+++ b/chrome/browser/lifetime/browser_close_manager.cc
@@ -62,7 +62,7 @@ void BrowserCloseManager::StartClosingBrowsers() {
void BrowserCloseManager::CancelBrowserClose() {
browser_shutdown::SetTryingToQuit(false);
for (auto* browser : *BrowserList::GetInstance()) {
sky 2017/03/14 00:04:05 no {}
zmin 2017/03/14 17:46:47 Done.
- browser->ResetBeforeUnloadHandlers();
+ browser->ResetTryToCloseWindow();
}
}
@@ -73,7 +73,8 @@ void BrowserCloseManager::TryToCloseBrowsers() {
// OnBrowserReportCloseable with the result. If the user confirms the close,
// this will trigger TryToCloseBrowsers to try again.
for (auto* browser : *BrowserList::GetInstance()) {
- if (browser->CallBeforeUnloadHandlers(
+ if (browser->TryToCloseWindow(
+ false,
base::Bind(&BrowserCloseManager::OnBrowserReportCloseable, this))) {
current_browser_ = browser;
return;
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_manager.cc » ('j') | chrome/browser/ui/browser.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698