Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

Issue 2681193003: Page load metrics observers cleanup (Closed)
Patch Set: address comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
index 5ff0447ae95738224d9f650e9e71e4371ae2a22e..4df6470fce4823aedbd34e4fde8a5f0b082aae06 100644
--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
@@ -9,6 +9,7 @@
#include "base/test/histogram_tester.h"
#include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
#include "chrome/browser/page_load_metrics/page_load_tracker.h"
+#include "chrome/common/url_constants.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "content/public/test/web_contents_tester.h"
#include "third_party/WebKit/public/platform/WebInputEvent.h"
@@ -42,6 +43,12 @@ class PageLoadMetricsObserverTestHarness
void NavigateWithPageTransitionAndCommit(const GURL& url,
ui::PageTransition transition);
+ // Navigates to a URL that is not tracked by page_load_metrics. Useful for
+ // forcing the OnComplete method of a PageLoadMetricsObserver to run.
+ void NavigateToUntrackedUrl() {
+ NavigateAndCommit(GURL(url::kAboutBlankURL));
+ }
+
// Call this to simulate sending a PageLoadTiming IPC from the render process
// to the browser process. These will update the timing information for the
// most recently committed navigation.
@@ -49,6 +56,9 @@ class PageLoadMetricsObserverTestHarness
void SimulateTimingAndMetadataUpdate(const PageLoadTiming& timing,
const PageLoadMetadata& metadata);
+ // Simulates a loaded resource.
+ void SimulateLoadedResource(const ExtraRequestInfo& info);
+
// Simulates a user input.
void SimulateInputEvent(const blink::WebInputEvent& event);

Powered by Google App Engine
This is Rietveld 408576698