Factor out snapshot helpers from main.cc.

Factor out snapshot helpers from main.cc.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/6500f6ee72e2928e03d0207096f6aa2166f83f59

[rmacnak, 2017-02-09 00:51:20]

rmacnak@google.com changed reviewers:
+ zra@google.com

[zra, 2017-02-09 16:15:38]

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/exit.h
File runtime/bin/exit.h (right):

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/exit.h#newc...
runtime/bin/exit.h:1: // Copyright (c) 2016, the Dart project authors.  Please
see the AUTHORS file
2017

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/exit.h#newc...
runtime/bin/exit.h:30: static void ErrorExit(int exit_code, const char* format,
...) {
Maybe rename this file error_exit.h and make a .cc file for this function.

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/snapshot.cc
File runtime/bin/snapshot.cc (right):

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/snapshot.cc...
runtime/bin/snapshot.cc:1: // Copyright (c) 2017, the Dart project authors. 
Please see the AUTHORS file
Maybe snapshot_utils.cc? Worried that there will be confusion because we already
have snapshot_in.cc and someone might think that snapshot_in.cc is used to
generate snapshot.cc.

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/snapshot.h
File runtime/bin/snapshot.h (right):

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/snapshot.h#...
runtime/bin/snapshot.h:25: };
DISALLOW_ALLOCATION()
DISALLOW_IMPLICIT_CONSTRUCTORS(Snapshot)

[rmacnak, 2017-02-10 02:11:57]

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/exit.h
File runtime/bin/exit.h (right):

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/exit.h#newc...
runtime/bin/exit.h:1: // Copyright (c) 2016, the Dart project authors.  Please
see the AUTHORS file
On 2017/02/09 16:15:38, zra wrote:
> 2017

Done.

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/exit.h#newc...
runtime/bin/exit.h:1: // Copyright (c) 2016, the Dart project authors.  Please
see the AUTHORS file
On 2017/02/09 16:15:38, zra wrote:
> 2017

Done.

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/exit.h#newc...
runtime/bin/exit.h:30: static void ErrorExit(int exit_code, const char* format,
...) {
On 2017/02/09 16:15:38, zra wrote:
> Maybe rename this file error_exit.h and make a .cc file for this function.

Done.

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/snapshot.cc
File runtime/bin/snapshot.cc (right):

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/snapshot.cc...
runtime/bin/snapshot.cc:1: // Copyright (c) 2017, the Dart project authors. 
Please see the AUTHORS file
On 2017/02/09 16:15:38, zra wrote:
> Maybe snapshot_utils.cc? Worried that there will be confusion because we
already
> have snapshot_in.cc and someone might think that snapshot_in.cc is used to
> generate snapshot.cc.

Good point. Done.

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/snapshot.h
File runtime/bin/snapshot.h (right):

https://codereview.chromium.org/2681193002/diff/40001/runtime/bin/snapshot.h#...
runtime/bin/snapshot.h:25: };
On 2017/02/09 16:15:38, zra wrote:
> DISALLOW_ALLOCATION()
> DISALLOW_IMPLICIT_CONSTRUCTORS(Snapshot)

Done.

[zra, 2017-02-10 15:42:34]

lgtm with nits

https://codereview.chromium.org/2681193002/diff/80001/runtime/bin/error_exit.cc
File runtime/bin/error_exit.cc (right):

https://codereview.chromium.org/2681193002/diff/80001/runtime/bin/error_exit....
runtime/bin/error_exit.cc:10: #include "bin/eventhandler.h"
alphabetize.

https://codereview.chromium.org/2681193002/diff/80001/runtime/bin/error_exit.h
File runtime/bin/error_exit.h (right):

https://codereview.chromium.org/2681193002/diff/80001/runtime/bin/error_exit....
runtime/bin/error_exit.h:8: #include "bin/log.h"
Probably don't need all these includes here anymore.

https://codereview.chromium.org/2681193002/diff/80001/runtime/bin/snapshot_ut...
File runtime/bin/snapshot_utils.cc (right):

https://codereview.chromium.org/2681193002/diff/80001/runtime/bin/snapshot_ut...
runtime/bin/snapshot_utils.cc:7: #include "include/dart_api.h"
alphabetize

[rmacnak, 2017-02-13 19:17:03]

https://codereview.chromium.org/2681193002/diff/80001/runtime/bin/error_exit.cc
File runtime/bin/error_exit.cc (right):

https://codereview.chromium.org/2681193002/diff/80001/runtime/bin/error_exit....
runtime/bin/error_exit.cc:10: #include "bin/eventhandler.h"
On 2017/02/10 15:42:34, zra wrote:
> alphabetize.

Done.

https://codereview.chromium.org/2681193002/diff/80001/runtime/bin/error_exit.h
File runtime/bin/error_exit.h (right):

https://codereview.chromium.org/2681193002/diff/80001/runtime/bin/error_exit....
runtime/bin/error_exit.h:8: #include "bin/log.h"
On 2017/02/10 15:42:34, zra wrote:
> Probably don't need all these includes here anymore.

Done.

https://codereview.chromium.org/2681193002/diff/80001/runtime/bin/snapshot_ut...
File runtime/bin/snapshot_utils.cc (right):

https://codereview.chromium.org/2681193002/diff/80001/runtime/bin/snapshot_ut...
runtime/bin/snapshot_utils.cc:7: #include "include/dart_api.h"
On 2017/02/10 15:42:34, zra wrote:
> alphabetize

Done.

[rmacnak, 2017-02-13 19:17:36]

Description was changed from

==========
Factor out snapshot helpers from main.cc.
==========

to

==========
Factor out snapshot helpers from main.cc.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6500f6ee72e2928e03d0207096f6aa2166f83f59
==========

[rmacnak, 2017-02-13 19:17:37]

Committed patchset #6 (id:100001) manually as
6500f6ee72e2928e03d0207096f6aa2166f83f59 (presubmit successful).