remoting/client/ios/facade/remoting_service.h - Issue 2681173002: Adding domain and facade supporting classes for remoting iOS app.

Side by Side Diff: remoting/client/ios/facade/remoting_service.h

Issue 2681173002: Adding domain and facade supporting classes for remoting iOS app. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_CLIENT_IOS_FACADE_REMOTING_SERCICE_H_

	6 #define REMOTING_CLIENT_IOS_FACADE_REMOTING_SERCICE_H_

	7

	8 #import "remoting/client/ios/domain/host.h"

	9 #import "remoting/client/ios/domain/user.h"

	10

	11 @interface RemotingService : NSObject

	12

	13 + (RemotingService*)sharedInstance;

	14

	15 - (BOOL)isAuthenticated;

	16 - (void)authenticateWithAccessCode:(NSString*)accessCode;
	Sergey Ulanov 2017/02/09 00:52:37 In OAuth it's usually referred to as access token, In OAuth it's usually referred to as access token, not access code. Access code can be confused with 12-digit number in It2Me. Also this method name is confusing. Should it be called setAccessToken? nicholss 2017/02/09 16:12:40 I was attempting to name this component: https://t Show quoted text On 2017/02/09 00:52:37, Sergey Ulanov wrote: > In OAuth it's usually referred to as access token, not access code. Access code > can be confused with 12-digit number in It2Me. > Also this method name is confusing. Should it be called setAccessToken? I was attempting to name this component: https://tools.ietf.org/html/rfc6749#section-4.1.3 in other places in the code base we call it an access_code. It seems according to the spec it is called "authorization_code" so I can change to that.
	17 - (User*)getUser;

	18 - (NSArray<Host>)getHosts;
	Sergey Ulanov 2017/02/09 00:52:37 This interface handles getting user info and getti This interface handles getting user info and getting host list from the directory. These 2 calls are handled by 2 different services, so I'm not sure if putting it all in the same class is the right thing to do. User-info query is already handled by OAuth layer, see https://codesearch.chromium.org/chromium/src/google_apis/gaia/gaia_oauth_clie... , so I'm not sure we need it here. Sergey Ulanov 2017/02/09 00:52:37 Will this the thread while the request is pending? Will this the thread while the request is pending? nicholss 2017/02/09 16:12:40 Yes, combining two services into one common endpoi Show quoted text On 2017/02/09 00:52:37, Sergey Ulanov wrote: > This interface handles getting user info and getting host list from the > directory. These 2 calls are handled by 2 different services, so I'm not sure if > putting it all in the same class is the right thing to do. User-info query is > already handled by OAuth layer, see > https://codesearch.chromium.org/chromium/src/google_apis/gaia/gaia_oauth_clie... > , so I'm not sure we need it here. Yes, combining two services into one common endpoint is the design pattern called 'facade'. I am trying to minimize the touch points between C++ and Obj-C. nicholss 2017/02/09 16:12:40 The intent is to make a call into a C++ class that Show quoted text On 2017/02/09 00:52:37, Sergey Ulanov wrote: > Will this the thread while the request is pending? The intent is to make a call into a C++ class that will handle the threading. The code might change to be callback or emitter based rather than blocking as it is now.
	19

	20 @end

	21

	22 #endif // REMOTING_CLIENT_IOS_FACADE_REMOTING_SERCICE_H_

OLD	NEW

« remoting/client/ios/domain/host.h ('K') | « remoting/client/ios/facade/BUILD.gn ('k') | remoting/client/ios/facade/remoting_service.mm » ('j') | no next file with comments »