MD Settings: in autofill section, change google-payment related entries to outlinks instead.

chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

Index: chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js b/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
index 7228b71e540ca93b5b58f24a995c0fbd00c57d63..b5a5824a39bb694d8e6450e1108870da12ebb4c9 100644
--- a/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
@@ -217,6 +217,32 @@ TEST_F('SettingsAutofillSectionBrowserTest', 'CreditCardTests', function() {
                    row.querySelector('#creditCardExpiration').textContent);
     });
 
+    test('verifyCreditCardRowButtonIsDropdownWhenLocal', function() {
+      var creditCard = FakeDataMaker.creditCardEntry();
+      creditCard.metadata.isLocal = true;
+      var section = self.createAutofillSection_([], [creditCard]);
+      var creditCardList = section.$.creditCardList;
+      var row = creditCardList.children[0];
+      assertTrue(!!row);
+      var menuButton = row.querySelector('#creditCardMenu');
+      assertFalse(menuButton.hidden);
+      var outlinkButton = row.querySelector('[is="paper-icon-button-light"');
+      assertTrue(outlinkButton.hidden);

[dpapad, 2017/02/10 20:24:08]

Since the paper-icon-button-light is in a dom-if it should not be even found in
the DOM. How come it exists here?

[scottchen, 2017/02/10 23:48:02]

..I forgot to update the test after changing it to dom-if, thanks for catching.

+    });
+
+    test('verifyCreditCardRowButtonIsOutlinkWhenRemote', function() {
+      var creditCard = FakeDataMaker.creditCardEntry();
+      creditCard.metadata.isLocal = false;
+      var section = self.createAutofillSection_([], [creditCard]);
+      var creditCardList = section.$.creditCardList;
+      var row = creditCardList.children[0];
+      assertTrue(!!row);
+      var menuButton = row.querySelector('#creditCardMenu');

[dpapad, 2017/02/10 20:24:08]

Same question here.

[scottchen, 2017/02/10 23:48:02]

same answer as above ;)

+      assertTrue(menuButton.hidden);
+      var outlinkButton = row.querySelector('[is="paper-icon-button-light"');
+      assertFalse(outlinkButton.hidden);
+    });
+
     test('verifyAddVsEditCreditCardTitle', function() {
       var newCreditCard = FakeDataMaker.emptyCreditCardEntry();
       var newCreditCardDialog = self.createCreditCardDialog_(newCreditCard);
@@ -430,6 +456,32 @@ TEST_F('SettingsAutofillSectionBrowserTest', 'AddressTests', function() {
       assertEquals(addressSummary, actualSummary);
     });
 
+    test('verifyAddressRowButtonIsDropdownWhenLocal', function() {
+      var address = FakeDataMaker.addressEntry();
+      address.metadata.isLocal = true;
+      var section = self.createAutofillSection_([address], []);
+      var addressList = section.$.addressList;
+      var row = addressList.children[0];
+      assertTrue(!!row);
+      var menuButton = row.querySelector('#addressMenu')
+      assertFalse(menuButton.hidden);
+      var outlinkButton = row.querySelector('[is="paper-icon-button-light"]');
+      assertTrue(outlinkButton.hidden);
+    });
+
+    test('verifyAddressRowButtonIsOutlinkWhenRemote', function() {
+      var address = FakeDataMaker.addressEntry();
+      address.metadata.isLocal = false;
+      var section = self.createAutofillSection_([address], []);
+      var addressList = section.$.addressList;
+      var row = addressList.children[0];
+      assertTrue(!!row);
+      var menuButton = row.querySelector('#addressMenu')
+      assertTrue(menuButton.hidden);
+      var outlinkButton = row.querySelector('[is="paper-icon-button-light"]');
+      assertFalse(outlinkButton.hidden);
+    });
+
     test('verifyAddAddressDialog', function() {
       return self.createAddressDialog_(
           FakeDataMaker.emptyAddressEntry()).then(function(dialog) {