Chromium Code Reviews| Index: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html |
| diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html |
| index e192458610ce401c227e3683675953e97be556d6..8edf1d82792ef0904116028018c7497a7b407dfb 100644 |
| --- a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html |
| +++ b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html |
| @@ -75,10 +75,15 @@ |
| $i18n{googlePayments} |
| </span> |
| </div> |
| - <paper-icon-button id="addressMenu" icon="cr:more-vert" |
| - tabindex$="[[tabIndex]]" alt="$i18n{overflowMenu}" |
| - on-tap="onAddressMenuTap_"> |
| - </paper-icon-button> |
| + <template is="dom-if" if="[[item.metadata.isLocal]]"> |
| + <paper-icon-button id="addressMenu" icon="cr:more-vert" |
| + on-tap="onAddressMenuTap_" alt="$i18n{overflowMenu}"> |
| + </paper-icon-button> |
| + </template> |
| + <template is="dom-if" if="[[!item.metadata.isLocal]]"> |
| + <button is="paper-icon-button-light" class="icon-external" |
|
dpapad
2017/02/10 20:24:08
Indentation off.
scottchen
2017/02/10 23:48:02
Done.
|
| + on-tap="onRemoteEditAddressTap_" actionable></button> |
|
dpapad
2017/02/10 20:24:08
Is there a point of applying actionable to a <butt
scottchen
2017/02/10 23:48:02
This was addressed in the reply to your comment fr
dpapad
2017/02/13 19:26:22
I see (must have missed your previous response). T
|
| + </template> |
| </div> |
| </template> |
| </div> |
| @@ -91,7 +96,6 @@ |
| <button id="menuEditAddress" class="dropdown-item" |
| on-tap="onMenuEditAddressTap_">$i18n{editAddress}</button> |
| <button id="menuRemoveAddress" class="dropdown-item" |
| - hidden$="[[!activeAddress.metadata.isLocal]]" |
| on-tap="onMenuRemoveAddressTap_">$i18n{removeAddress}</button> |
| </dialog> |
| <template is="dom-if" if="[[showAddressDialog_]]" restamp> |
| @@ -129,11 +133,16 @@ |
| <div class="expiration-column"> |
| <div id="creditCardExpiration" |
| class="expiration-date">[[expiration_(item)]]</div> |
| + </div> |
|
dpapad
2017/02/10 20:24:08
I noticed in the screenshot that the "Expiration D
scottchen
2017/02/10 23:48:02
Oops, fixed in newest patch: http://imgur.com/a/T4
|
| + <template is="dom-if" if="[[item.metadata.isLocal]]"> |
| <paper-icon-button id="creditCardMenu" icon="cr:more-vert" |
| - tabindex$="[[tabIndex]]" alt="$i18n{overflowMenu}" |
| - on-tap="onCreditCardMenuTap_"> |
| + on-tap="onCreditCardMenuTap_" alt="$i18n{overflowMenu}"> |
| </paper-icon-button> |
| - </div> |
| + </template> |
| + <template is="dom-if" if="[[!item.metadata.isLocal]]"> |
| + <button is="paper-icon-button-light" class="icon-external" |
| + on-tap="onRemoteEditCreditCardTap_" actionable></button> |
| + </template> |
| </div> |
| </template> |
| </div> |
| @@ -146,7 +155,6 @@ |
| <button id="menuEditCreditCard" class="dropdown-item" |
| on-tap="onMenuEditCreditCardTap_">$i18n{editCreditCard}</button> |
| <button id="menuRemoveCreditCard" class="dropdown-item" |
| - hidden$="[[!activeCreditCard.metadata.isLocal]]" |
| on-tap="onMenuRemoveCreditCardTap_">$i18n{removeCreditCard}</button> |
| <button id="menuClearCreditCard" class="dropdown-item" |
| on-tap="onMenuClearCreditCardTap_" |