Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2681143002: Parse using FileState, so use all analysis options. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/analysis_impl.dart View 3 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-08 17:20:52 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-08 17:30:18 UTC) #2
scheglov
3 years, 10 months ago (2017-02-08 18:06:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a980fc479039571b5a556dbef9d48934b0c4fb5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698