Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 2681123004: Handle Native("...") annotations in KernelBehaviorBuilder. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/core_types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index 01350e3207a4a9e9b9620d684213060c29729ebd..dd3249e13d6f3e0cccd5fe5e1234255f3bb97dec 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -1111,29 +1111,8 @@ class _CompilerCommonElements extends CommonElementsMixin {
LibraryElement mirrorsLibrary;
LibraryElement typedDataLibrary;
- // TODO(sigmund): possibly move this to target-specific collection of
- // elements, or refactor the library so that the helpers we need are in a
- // target-agnostic place. Currently we are using @patch and @Native from
- // here. We hope we can make those independent of the backend and generic
- // enough so the patching algorithm can work without being configured for a
- // specific backend.
- LibraryElement jsHelperLibrary;
-
_CompilerCommonElements(this.environment, this.resolution, this.reporter);
- // From dart:_js_helper
- // TODO(sigmund,johnniwinther): refactor needed: either these move to a
- // backend-specific collection of helpers, or the helper code moves to a
- // backend agnostic library (see commend above on [jsHelperLibrary].
-
- ClassElement _patchAnnotationClass;
- ClassElement get patchAnnotationClass =>
- _patchAnnotationClass ??= _findLibraryMember(jsHelperLibrary, '_Patch');
-
- ClassElement _nativeAnnotationClass;
- ClassElement get nativeAnnotationClass =>
- _nativeAnnotationClass ??= _findLibraryMember(jsHelperLibrary, 'Native');
-
@override
ResolutionDynamicType get dynamicType => const ResolutionDynamicType();
@@ -1147,8 +1126,6 @@ class _CompilerCommonElements extends CommonElementsMixin {
typedDataLibrary = library;
} else if (uri == Uris.dart_mirrors) {
mirrorsLibrary = library;
- } else if (uri == js_backend.BackendHelpers.DART_JS_HELPER) {
- jsHelperLibrary = library;
}
}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/core_types.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698