Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2681123004: Handle Native("...") annotations in KernelBehaviorBuilder. (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle Native("...") annotations in KernelBehaviorBuilder. Closes #28157 R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/1567a4c21bc173837b2243372c09eb7507d72684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -82 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +0 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/core_types.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 2 chunks +13 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_adapter.dart View 5 chunks +24 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/elements.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 5 chunks +31 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 5 chunks +23 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-09 13:16:35 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
3 years, 10 months ago (2017-02-09 21:04:31 UTC) #3
Johnni Winther
3 years, 10 months ago (2017-02-10 09:49:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1567a4c21bc173837b2243372c09eb7507d72684 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698