Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2681123003: Mark deferred loading test as failing for vm-kernel-precompiled (Closed)

Created:
3 years, 10 months ago by Dmitry Stefantsov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark deferred loading test as failing for vm-kernel-precompiled This is a known issue, see dartbug.com/28335 R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/bbd687197bc96b4d7a0555d3f0cd0e1e64c2b672

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change expected status of vm-kernel-precomp for deferred loading test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/language/language_kernel.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dmitry Stefantsov
3 years, 10 months ago (2017-02-09 09:20:41 UTC) #2
Kevin Millikin (Google)
LGTM with the change below. https://codereview.chromium.org/2681123003/diff/1/tests/language/language_kernel.status File tests/language/language_kernel.status (right): https://codereview.chromium.org/2681123003/diff/1/tests/language/language_kernel.status#newcode211 tests/language/language_kernel.status:211: deferred_regression_28678_test: Fail # Issue ...
3 years, 10 months ago (2017-02-09 09:54:07 UTC) #3
Dmitry Stefantsov
3 years, 10 months ago (2017-02-09 10:05:35 UTC) #4
Dmitry Stefantsov
3 years, 10 months ago (2017-02-09 10:18:40 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
bbd687197bc96b4d7a0555d3f0cd0e1e64c2b672 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698