Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2681033008: Update status for front-end unit tests (Closed)

Created:
3 years, 10 months ago by Bill Hesse
Modified:
3 years, 10 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status for front-end unit tests BUG=https://github.com/dart-lang/sdk/issues/28698 TBR=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/f7e08cc102c9810f50595849edbfe24b65ecffa0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bill Hesse
3 years, 10 months ago (2017-02-09 02:02:51 UTC) #3
Bill Hesse
Committed patchset #1 (id:1) manually as f7e08cc102c9810f50595849edbfe24b65ecffa0 (presubmit successful).
3 years, 10 months ago (2017-02-09 02:03:43 UTC) #5
ahe
lgtm My understanding is that these tests will be run on the package bots, correct? ...
3 years, 10 months ago (2017-02-09 08:28:09 UTC) #6
Paul Berry
On 2017/02/09 08:28:09, ahe wrote: > lgtm > > My understanding is that these tests ...
3 years, 10 months ago (2017-02-09 13:14:03 UTC) #7
ahe
3 years, 10 months ago (2017-02-09 13:17:47 UTC) #8
Message was sent while issue was closed.
On 2017/02/09 13:14:03, Paul Berry wrote:
> On 2017/02/09 08:28:09, ahe wrote:
> > lgtm
> > 
> > My understanding is that these tests will be run on the package bots,
correct?
> > 
> > Will they be run on the analyzer bots?
> 
> The analyzer bots run the tests in both pkg/front_end and pkg/analyzer.  We
> asked Bill to set this up because the package bots are so frequently red that
we
> were not noticing failures.  I don't know whether the package bots still run
> these tests or not.

That's great. I think this means that they are skipped on vm-kernel bots (as
$use_sdk is false there), but run on the analyzer bots (as $use_sdk is true
there). So for test coverage we should be good.

Powered by Google App Engine
This is Rietveld 408576698