Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_item_unittest.mm

Issue 2680973009: [ObjC ARC] Converts ios/chrome/browser/ui/tools_menu:unit_tests to ARC. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/tools_menu/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/tools_menu/tools_menu_view_item_unittest.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_view_item_unittest.mm b/ios/chrome/browser/ui/tools_menu/tools_menu_view_item_unittest.mm
index 5786e57d00cffeb222fe0371fc2bf13c2a2298d0..ddd69acd7903b974544634870cd01265a2ff44b0 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_view_item_unittest.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_view_item_unittest.mm
@@ -6,41 +6,40 @@
#import <UIKit/UIKit.h>
-#include "base/mac/scoped_nsobject.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
class ToolsMenuViewItemTest : public PlatformTest {
protected:
void SetUp() override {
- toolsMenuViewItem_.reset([[ToolsMenuViewItem alloc] init]);
+ toolsMenuViewItem_ = [[ToolsMenuViewItem alloc] init];
}
- base::scoped_nsobject<ToolsMenuViewItem> toolsMenuViewItem_;
+ ToolsMenuViewItem* toolsMenuViewItem_;
};
TEST_F(ToolsMenuViewItemTest, CustomizeCellAccessibilityTrait) {
- base::scoped_nsobject<ToolsMenuViewCell> cell1(
- [[ToolsMenuViewCell alloc] init]);
- base::scoped_nsobject<ToolsMenuViewCell> cell2(
- [[ToolsMenuViewCell alloc] init]);
+ ToolsMenuViewCell* cell1 = [[ToolsMenuViewCell alloc] init];
+ ToolsMenuViewCell* cell2 = [[ToolsMenuViewCell alloc] init];
[toolsMenuViewItem_ setActive:YES];
[cell1 setAccessibilityTraits:UIAccessibilityTraitNotEnabled];
[cell1 configureForMenuItem:toolsMenuViewItem_];
- EXPECT_FALSE(cell1.get().accessibilityTraits &
- UIAccessibilityTraitNotEnabled);
+ EXPECT_FALSE(cell1.accessibilityTraits & UIAccessibilityTraitNotEnabled);
[toolsMenuViewItem_ setActive:NO];
[cell2 configureForMenuItem:toolsMenuViewItem_];
- EXPECT_TRUE(cell2.get().accessibilityTraits & UIAccessibilityTraitNotEnabled);
+ EXPECT_TRUE(cell2.accessibilityTraits & UIAccessibilityTraitNotEnabled);
// Happens when cell2 is reused.
[toolsMenuViewItem_ setActive:YES];
[cell2 configureForMenuItem:toolsMenuViewItem_];
- EXPECT_FALSE(cell2.get().accessibilityTraits &
- UIAccessibilityTraitNotEnabled);
+ EXPECT_FALSE(cell2.accessibilityTraits & UIAccessibilityTraitNotEnabled);
}
} // namespace
« no previous file with comments | « ios/chrome/browser/ui/tools_menu/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698