ui/views/controls/scroll_view.h - Issue 2680953002: Remove GraphicsLayer::didScroll and directly call ScrollableArea::didScroll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/scroll_view.h

Issue 2680953002: Remove GraphicsLayer::didScroll and directly call ScrollableArea::didScroll (Closed)

Patch Set: Incorporate reviewer comments: more tests, less bad tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/scroll_view.h

diff --git a/ui/views/controls/scroll_view.h b/ui/views/controls/scroll_view.h

index 6dc43932ee76c365d30c6337d57a9c9cab99fce7..db38b2c8e7560cab7415c0d73caf48124207afcc 100644

--- a/ui/views/controls/scroll_view.h

+++ b/ui/views/controls/scroll_view.h

@@ -149,7 +149,7 @@ class VIEWS_EXPORT ScrollView : public View, public ScrollBarController {

bool ScrollsWithLayers() const;

// Callback entrypoint when hosted Layers are scrolled by the Compositor.

- void OnLayerScrolled();

+ void OnLayerScrolled(const gfx::ScrollOffset& offset);

// Horizontally scrolls the header (if any) to match the contents.

void ScrollHeader();

« no previous file with comments | « ui/compositor/layer.cc ('k') | ui/views/controls/scroll_view.cc » ('j') | no next file with comments »