third_party/WebKit/public/platform/WebLayer.h - Issue 2680953002: Remove GraphicsLayer::didScroll and directly call ScrollableArea::didScroll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebLayer.h

Issue 2680953002: Remove GraphicsLayer::didScroll and directly call ScrollableArea::didScroll (Closed)

Patch Set: Incorporate reviewer comments: more tests, less bad tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/platform/WebLayer.h

diff --git a/third_party/WebKit/public/platform/WebLayer.h b/third_party/WebKit/public/platform/WebLayer.h

index e51ae30597e022635e356738d74e0d78eaac60e3..9da1a40e3a5100f3756929efc4fe47d714d82fa3 100644

--- a/third_party/WebKit/public/platform/WebLayer.h

+++ b/third_party/WebKit/public/platform/WebLayer.h

@@ -29,7 +29,7 @@

#include "WebBlendMode.h"

#include "WebColor.h"

#include "WebCommon.h"

-#include "WebDoublePoint.h"

+#include "WebFloatPoint.h"

#include "WebFloatPoint3D.h"

#include "WebFloatSize.h"

#include "WebPoint.h"

@@ -158,8 +158,8 @@ class WebLayer {

virtual void setClipParent(WebLayer*) = 0;

// Scrolling

- virtual void setScrollPositionDouble(WebDoublePoint) = 0;

- virtual WebDoublePoint scrollPositionDouble() const = 0;

+ virtual void setScrollPosition(WebFloatPoint) = 0;

+ virtual WebFloatPoint scrollPosition() const = 0;

// To set a WebLayer as scrollable we must specify the corresponding clip

// layer.