Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

Issue 2680953002: Remove GraphicsLayer::didScroll and directly call ScrollableArea::didScroll (Closed)
Patch Set: Incorporate reviewer comments: more tests, less bad tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
index 68047c4271e265b1a7a1b678fcaa820b9e2a7470..b3abc4504e907b8355676e551333833b1ee886f5 100644
--- a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
@@ -226,8 +226,8 @@ TEST_P(ScrollingCoordinatorTest, fastFractionalScrollingDiv) {
WebLayer* webScrollLayer =
compositedLayerMapping->scrollingContentsLayer()->platformLayer();
ASSERT_TRUE(webScrollLayer);
- ASSERT_NEAR(1.2f, webScrollLayer->scrollPositionDouble().x, 0.01f);
- ASSERT_NEAR(1.2f, webScrollLayer->scrollPositionDouble().y, 0.01f);
+ ASSERT_NEAR(1.2f, webScrollLayer->scrollPosition().x, 0.01f);
+ ASSERT_NEAR(1.2f, webScrollLayer->scrollPosition().y, 0.01f);
RuntimeEnabledFeatures::setFractionalScrollOffsetsEnabled(
origFractionalOffsetsEnabled);
@@ -740,7 +740,7 @@ TEST_P(ScrollingCoordinatorTest, rtlIframe) {
->isOverlayScrollbar()
? 0
: 15);
- ASSERT_EQ(expectedScrollPosition, webScrollLayer->scrollPositionDouble().x);
+ ASSERT_EQ(expectedScrollPosition, webScrollLayer->scrollPosition().x);
}
TEST_P(ScrollingCoordinatorTest, setupScrollbarLayerShouldNotCrash) {
« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarTestSuite.h ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698