Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp

Issue 2680953002: Remove GraphicsLayer::didScroll and directly call ScrollableArea::didScroll (Closed)
Patch Set: Incorporate reviewer comments: more tests, less bad tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
index 08c88645d8e095511f00f58c4e37968e6eb164f1..7dd4b73cfa4345c3726cf9d8ac07eb4f9d0f0e80 100644
--- a/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
@@ -204,16 +204,4 @@ class FakeScrollableArea : public GarbageCollectedFinalized<FakeScrollableArea>,
ScrollOffset m_scrollOffset;
};
-TEST_F(GraphicsLayerTest, applyScrollToScrollableArea) {
- FakeScrollableArea* scrollableArea = FakeScrollableArea::create();
- m_graphicsLayer->setScrollableArea(scrollableArea, false);
-
- WebDoublePoint scrollPosition(7, 9);
- m_platformLayer->setScrollPositionDouble(scrollPosition);
- m_graphicsLayer->didScroll();
-
- EXPECT_FLOAT_EQ(scrollPosition.x, scrollableArea->getScrollOffset().width());
- EXPECT_FLOAT_EQ(scrollPosition.y, scrollableArea->getScrollOffset().height());
-}
-
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698