Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: cc/layers/layer.cc

Issue 2680953002: Remove GraphicsLayer::didScroll and directly call ScrollableArea::didScroll (Closed)
Patch Set: Incorporate reviewer comments: more tests, less bad tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/layer.h ('k') | cc/trees/layer_tree_host_unittest_scroll.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer.cc
diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc
index 3446f38d659eca9b59008e00b341ce81d6f840f6..5f777afcac3be247bdf526caa6fa875a3d3e0bf0 100644
--- a/cc/layers/layer.cc
+++ b/cc/layers/layer.cc
@@ -823,7 +823,8 @@ void Layer::SetScrollOffsetFromImplSide(
property_trees->needs_rebuild = true;
if (!inputs_.did_scroll_callback.is_null())
- inputs_.did_scroll_callback.Run();
+ inputs_.did_scroll_callback.Run(scroll_offset);
+
// The callback could potentially change the layer structure:
// "this" may have been destroyed during the process.
}
« no previous file with comments | « cc/layers/layer.h ('k') | cc/trees/layer_tree_host_unittest_scroll.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698