Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2497)

Unified Diff: cc/blink/web_layer_impl.cc

Issue 2680953002: Remove GraphicsLayer::didScroll and directly call ScrollableArea::didScroll (Closed)
Patch Set: Incorporate reviewer comments: more tests, less bad tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/blink/web_layer_impl.h ('k') | cc/layers/layer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/blink/web_layer_impl.cc
diff --git a/cc/blink/web_layer_impl.cc b/cc/blink/web_layer_impl.cc
index 73e62b3e66fc0f018aa19bf2484402d08a1b69af..43d7caa7f202b524f31c1b004f3600d19d70183b 100644
--- a/cc/blink/web_layer_impl.cc
+++ b/cc/blink/web_layer_impl.cc
@@ -217,13 +217,13 @@ bool WebLayerImpl::hasTickingAnimationForTesting() {
return layer_->HasTickingAnimationForTesting();
}
-void WebLayerImpl::setScrollPositionDouble(blink::WebDoublePoint position) {
+void WebLayerImpl::setScrollPosition(blink::WebFloatPoint position) {
layer_->SetScrollOffset(gfx::ScrollOffset(position.x, position.y));
}
-blink::WebDoublePoint WebLayerImpl::scrollPositionDouble() const {
- return blink::WebDoublePoint(layer_->scroll_offset().x(),
- layer_->scroll_offset().y());
+blink::WebFloatPoint WebLayerImpl::scrollPosition() const {
+ return blink::WebFloatPoint(layer_->scroll_offset().x(),
+ layer_->scroll_offset().y());
}
void WebLayerImpl::setScrollClipLayer(WebLayer* clip_layer) {
@@ -416,7 +416,8 @@ void WebLayerImpl::setScrollClient(blink::WebLayerScrollClient* scroll_client) {
base::Bind(&blink::WebLayerScrollClient::didScroll,
base::Unretained(scroll_client)));
} else {
- layer_->set_did_scroll_callback(base::Closure());
+ layer_->set_did_scroll_callback(
+ base::Callback<void(const gfx::ScrollOffset&)>());
}
}
« no previous file with comments | « cc/blink/web_layer_impl.h ('k') | cc/layers/layer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698