cc/blink/web_layer_impl.cc - Issue 2680953002: Remove GraphicsLayer::didScroll and directly call ScrollableArea::didScroll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/blink/web_layer_impl.cc

Issue 2680953002: Remove GraphicsLayer::didScroll and directly call ScrollableArea::didScroll (Closed)

Patch Set: Remove unneeded tests from parent patch Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/blink/web_layer_impl.cc

diff --git a/cc/blink/web_layer_impl.cc b/cc/blink/web_layer_impl.cc

index 73e62b3e66fc0f018aa19bf2484402d08a1b69af..345ea3ea64adec1aec1c40c02c376dca598f7d4a 100644

--- a/cc/blink/web_layer_impl.cc

+++ b/cc/blink/web_layer_impl.cc

@@ -416,7 +416,8 @@ void WebLayerImpl::setScrollClient(blink::WebLayerScrollClient* scroll_client) {

base::Bind(&blink::WebLayerScrollClient::didScroll,

base::Unretained(scroll_client)));

} else {

- layer_->set_did_scroll_callback(base::Closure());

+ layer_->set_did_scroll_callback(

+ base::Callback<void(const gfx::ScrollOffset&)>());

}