Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollbarTestSuite.h

Issue 2680953002: Remove GraphicsLayer::didScroll and directly call ScrollableArea::didScroll (Closed)
Patch Set: Incorporate reviewer comments: more tests, less bad tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ScrollbarTestSuite_h 5 #ifndef ScrollbarTestSuite_h
6 #define ScrollbarTestSuite_h 6 #define ScrollbarTestSuite_h
7 7
8 #include "platform/heap/GarbageCollected.h" 8 #include "platform/heap/GarbageCollected.h"
9 #include "platform/scroll/ScrollableArea.h" 9 #include "platform/scroll/ScrollableArea.h"
10 #include "platform/scroll/Scrollbar.h" 10 #include "platform/scroll/Scrollbar.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 } 56 }
57 IntSize minimumScrollOffsetInt() const override { return IntSize(); } 57 IntSize minimumScrollOffsetInt() const override { return IntSize(); }
58 IntSize maximumScrollOffsetInt() const override { 58 IntSize maximumScrollOffsetInt() const override {
59 return expandedIntSize(m_maximumScrollOffset); 59 return expandedIntSize(m_maximumScrollOffset);
60 } 60 }
61 int visibleHeight() const override { return 768; } 61 int visibleHeight() const override { return 768; }
62 int visibleWidth() const override { return 1024; } 62 int visibleWidth() const override { return 1024; }
63 bool scrollAnimatorEnabled() const override { return false; } 63 bool scrollAnimatorEnabled() const override { return false; }
64 int pageStep(ScrollbarOrientation) const override { return 0; } 64 int pageStep(ScrollbarOrientation) const override { return 0; }
65 void scrollControlWasSetNeedsPaintInvalidation() {} 65 void scrollControlWasSetNeedsPaintInvalidation() {}
66 void setScrollOrigin(const IntPoint& origin) {
67 ScrollableArea::setScrollOrigin(origin);
68 }
66 69
67 RefPtr<WebTaskRunner> getTimerTaskRunner() const final { 70 RefPtr<WebTaskRunner> getTimerTaskRunner() const final {
68 return Platform::current()->currentThread()->scheduler()->timerTaskRunner(); 71 return Platform::current()->currentThread()->scheduler()->timerTaskRunner();
69 } 72 }
70 73
71 using ScrollableArea::horizontalScrollbarNeedsPaintInvalidation; 74 using ScrollableArea::horizontalScrollbarNeedsPaintInvalidation;
72 using ScrollableArea::verticalScrollbarNeedsPaintInvalidation; 75 using ScrollableArea::verticalScrollbarNeedsPaintInvalidation;
73 using ScrollableArea::clearNeedsPaintInvalidationForScrollControls; 76 using ScrollableArea::clearNeedsPaintInvalidationForScrollControls;
74 77
75 DEFINE_INLINE_VIRTUAL_TRACE() { ScrollableArea::trace(visitor); } 78 DEFINE_INLINE_VIRTUAL_TRACE() { ScrollableArea::trace(visitor); }
76 79
77 protected: 80 protected:
78 explicit MockScrollableArea() : m_maximumScrollOffset(ScrollOffset(0, 100)) {} 81 explicit MockScrollableArea() : m_maximumScrollOffset(ScrollOffset(0, 100)) {}
79 explicit MockScrollableArea(const ScrollOffset& offset) 82 explicit MockScrollableArea(const ScrollOffset& offset)
80 : m_maximumScrollOffset(offset) {} 83 : m_maximumScrollOffset(offset) {}
81 84
82 private: 85 private:
83 void setMaximumScrollOffset(const ScrollOffset& maximumScrollOffset) { 86 void setMaximumScrollOffset(const ScrollOffset& maximumScrollOffset) {
84 m_maximumScrollOffset = maximumScrollOffset; 87 m_maximumScrollOffset = maximumScrollOffset;
85 } 88 }
86 89
87 ScrollOffset m_scrollOffset; 90 ScrollOffset m_scrollOffset;
88 ScrollOffset m_maximumScrollOffset; 91 ScrollOffset m_maximumScrollOffset;
89 }; 92 };
90 93
91 } // namespace blink 94 } // namespace blink
92 95
93 #endif 96 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698