third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2680943004: Make FrameSelection to hold non-canonicalized positions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2680943004: Make FrameSelection to hold non-canonicalized positions (Closed)

Patch Set: 2014-02-14T23:34:22 Update TestExpectation to include extend-{0,2,4}0.html and selectAllChildren.html Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 60ef11f88e84ba158b36575c08318e9e913148e2..49b8405a80234f1ff2ac828e0c81de937bfd7fbf 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -1979,7 +1979,8 @@ bool FrameView::computeCompositedSelection(LocalFrame& frame,

if (!frame.view() || frame.view()->shouldThrottleRendering())

return false;

- const VisibleSelection& visibleSelection = frame.selection().selection();

+ const VisibleSelection& visibleSelection =

+ frame.selection().computeVisibleSelectionInDOMTree();

if (visibleSelection.isNone() || !frame.selection().isHandleVisible())

return false;