Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2680903002: Separate fasta and analyzer scanner tests. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Separate fasta and analyzer scanner tests. This makes it easier to run one set of tests or the other. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/6c86822bf5e905e129efd05008ebe3d436e4261a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+602 lines, -587 lines) Patch
A pkg/front_end/test/scanner_fasta_test.dart View 1 chunk +527 lines, -0 lines 0 comments Download
M pkg/front_end/test/scanner_test.dart View 13 chunks +75 lines, -587 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 10 months ago (2017-02-07 18:47:34 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-08 00:02:29 UTC) #3
Paul Berry
3 years, 10 months ago (2017-02-08 01:36:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c86822bf5e905e129efd05008ebe3d436e4261a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698