Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2680883004: Resolve Library/Part/PartOf/Directive(s) in AST without tasks. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resolve Library/Part/PartOf/Directive(s) in AST without tasks. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fe3286ad4be6ab1324a12794f326871a495bd4aa

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -31 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/analysis_impl.dart View 15 chunks +150 lines, -29 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +1 line, -1 line 2 comments Download
M pkg/analyzer/test/src/dart/analysis/base.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +150 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 10 months ago (2017-02-08 01:10:29 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2680883004/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart File pkg/analyzer/lib/src/dart/analysis/driver.dart (right): https://codereview.chromium.org/2680883004/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart#newcode244 pkg/analyzer/lib/src/dart/analysis/driver.dart:244: this.analyzeWithoutTasks: true}) Did you intend to enable this ...
3 years, 10 months ago (2017-02-08 01:19:03 UTC) #2
scheglov
https://codereview.chromium.org/2680883004/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart File pkg/analyzer/lib/src/dart/analysis/driver.dart (right): https://codereview.chromium.org/2680883004/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart#newcode244 pkg/analyzer/lib/src/dart/analysis/driver.dart:244: this.analyzeWithoutTasks: true}) On 2017/02/08 01:19:02, Brian Wilkerson wrote: > ...
3 years, 10 months ago (2017-02-08 02:13:48 UTC) #3
scheglov
3 years, 10 months ago (2017-02-08 02:20:47 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
fe3286ad4be6ab1324a12794f326871a495bd4aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698