Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3724)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 2680883003: Temporarily re-introduce load-component-extension switch. (Closed)
Patch Set: --enable-chromedriver -> --enable-automation Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/chrome_switches.h » ('j') | chrome/common/chrome_switches.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 732779d4c7ba0ca0d33e76fe75ffab240b1f5a03..ec0c59294f862aae7953720160f274f76f6b43a1 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -439,6 +439,12 @@ void ExtensionService::Init() {
LoadExtensionsFromCommandLineFlag(switches::kDisableExtensionsExcept);
if (extensions_enabled_)
LoadExtensionsFromCommandLineFlag(switches::kLoadExtension);
+ // TODO(samuong): Remove this when ChromeDriver stops supporting Chrome 56.
+ // ChromeDriver has no way of determining the Chrome version until after
+ // launch, so it needs to continue passing load-component-extension until it
+ // stops supporting Chrome 56.
Devlin 2017/02/14 20:44:41 Clarify that this only loads the extension as a re
Devlin 2017/02/14 20:44:41 ETA?
samuong 2017/02/14 21:22:49 Done. ChromeDriver supports the current and previo
+ if (command_line_->HasSwitch(switches::kEnableAutomation))
Devlin 2017/02/14 20:44:41 Maybe something like: if (command_line_->HasSwitch
samuong 2017/02/14 21:22:49 Done.
+ LoadExtensionsFromCommandLineFlag(switches::kLoadComponentExtension);
EnabledReloadableExtensions();
MaybeFinishShutdownDelayed();
SetReadyAndNotifyListeners();
« no previous file with comments | « no previous file | chrome/common/chrome_switches.h » ('j') | chrome/common/chrome_switches.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698