Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h

Issue 268083002: Add tests for drag and drop for Linux Aura (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h
diff --git a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h
index d4092489154ac5c4c79764bf35918fd3ddabb141..cd008f12a20c31a4e2bc86b8ecc44eed0e1a3543 100644
--- a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h
+++ b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h
@@ -97,6 +97,17 @@ class VIEWS_EXPORT DesktopDragDropClientAuraX11
virtual void OnMouseReleased() OVERRIDE;
virtual void OnMoveLoopEnded() OVERRIDE;
+ protected:
+ // The following methods are virtual for the sake of testing.
+
+ // Returns the topmost X11 window at |screen_point| and returns it if it is
varkha 2014/05/07 03:11:08 Nit: Do you want to rephrase it a bit (remove repe
pkotwicz 2014/05/07 15:16:36 Done.
+ // Xdnd aware. Returns NULL otherwise.
+ virtual ::Window FindWindowFor(const gfx::Point& screen_point);
+
+ // Sends |xev| to |xid|, optionally short circuiting the round trip to the X
+ // server.
+ virtual void SendXClientEvent(::Window xid, XEvent* xev);
+
private:
enum SourceState {
// |source_current_window_| will receive a drop once we receive an
@@ -166,10 +177,6 @@ class VIEWS_EXPORT DesktopDragDropClientAuraX11
unsigned long event_time);
void SendXdndDrop(::Window dest_window);
- // Sends |xev| to |xid|, optionally short circuiting the round trip to the X
- // server.
- void SendXClientEvent(::Window xid, XEvent* xev);
-
// A nested message loop that notifies this object of events through the
// X11WholeScreenMoveLoopDelegate interface.
X11WholeScreenMoveLoop move_loop_;

Powered by Google App Engine
This is Rietveld 408576698