Add tests for drag and drop for Linux Aura

Add tests for drag and drop for Linux Aura

This CL also adds handling for rejecting the drop in the XdndFinished message.

TEST=DesktopDragDropClientAuraX11Test.*
BUG=None
TBR=varkha, erg

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269232

[pkotwicz, 2014-05-04 23:13:14]

Valery, PTAL

[pkotwicz, 2014-05-05 14:37:27]

I did not write any tests for the drop path because I could not think of any
useful tests. Wrt to testing spec compiance, testing the drag path is probably
sufficient. This is where the majority of the bugs that I found were too

[pkotwicz, 2014-05-07 02:19:31]

Ping?

[pkotwicz, 2014-05-07 02:19:32]

Ping?

[varkha, 2014-05-07 03:11:07]

Lgtm with couple nits. Beautiful tests and amazingly no real windows were harmed
in making those tests!

https://codereview.chromium.org/268083002/diff/40001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h (right):

https://codereview.chromium.org/268083002/diff/40001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h:103: // Returns
the topmost X11 window at |screen_point| and returns it if it is
Nit: Do you want to rephrase it a bit (remove repeated returns)?

https://codereview.chromium.org/268083002/diff/40001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc
(right):

https://codereview.chromium.org/268083002/diff/40001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc:574:
std::vector<XClientMessageEvent> events2 = collector2.PopAllEvents();
Nit: Could use the same events vector for collection.

[pkotwicz, 2014-05-07 15:16:36]

Elliot, can you please take a look?

https://codereview.chromium.org/268083002/diff/40001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h (right):

https://codereview.chromium.org/268083002/diff/40001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h:103: // Returns
the topmost X11 window at |screen_point| and returns it if it is
On 2014/05/07 03:11:08, varkha wrote:
> Nit: Do you want to rephrase it a bit (remove repeated returns)?

Done.

https://codereview.chromium.org/268083002/diff/40001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc
(right):

https://codereview.chromium.org/268083002/diff/40001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc:574:
std::vector<XClientMessageEvent> events2 = collector2.PopAllEvents();
I think that keeping the vectors separate is clearer.

[Elliot Glaysher, 2014-05-07 17:48:28]

lgtm

[pkotwicz, 2014-05-07 19:02:26]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-05-07 19:03:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/268083002/80001

[commit-bot: I haz the power, 2014-05-08 01:30:01]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
  chromium_presubmit on tryserver.chromium
  linux_chromium_rel on tryserver.chromium
  win_chromium_rel on tryserver.chromium

[pkotwicz, 2014-05-08 02:24:20]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-05-08 02:25:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/268083002/90001

[commit-bot: I haz the power, 2014-05-08 06:54:10]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
  win_chromium_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-08 06:57:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 06:57:44]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium

[pkotwicz, 2014-05-08 14:47:32]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-05-08 14:49:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/268083002/90001

[commit-bot: I haz the power, 2014-05-09 11:52:03]

Change committed as 269232