Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2680823002: Extract InterceptorData from JavaScriptBackend. (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -319 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 21 chunks +28 lines, -250 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A pkg/compiler/lib/src/js_backend/interceptor_data.dart View 1 1 chunk +245 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/native_data.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 3 chunks +16 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 4 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 5 chunks +10 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 7 chunks +10 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-07 14:56:48 UTC) #2
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/2680823002/diff/1/pkg/compiler/lib/src/js_backend/interceptor_data.dart File pkg/compiler/lib/src/js_backend/interceptor_data.dart (right): https://codereview.chromium.org/2680823002/diff/1/pkg/compiler/lib/src/js_backend/interceptor_data.dart#newcode24 pkg/compiler/lib/src/js_backend/interceptor_data.dart:24: /** while we are at it, let's turn ...
3 years, 10 months ago (2017-02-08 00:20:37 UTC) #3
Johnni Winther
https://codereview.chromium.org/2680823002/diff/1/pkg/compiler/lib/src/js_backend/interceptor_data.dart File pkg/compiler/lib/src/js_backend/interceptor_data.dart (right): https://codereview.chromium.org/2680823002/diff/1/pkg/compiler/lib/src/js_backend/interceptor_data.dart#newcode24 pkg/compiler/lib/src/js_backend/interceptor_data.dart:24: /** On 2017/02/08 00:20:36, Siggi Cherem (dart-lang) wrote: > ...
3 years, 10 months ago (2017-02-08 09:56:02 UTC) #4
Johnni Winther
3 years, 10 months ago (2017-02-08 10:05:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
af4b2b8e30f6bce0da2790e7ec5853caedefa165 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698